WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 15 months ago

#23428 new defect (bug)

comments_open causes PHP notice in certain cases

Reported by: willnorris Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 2.5
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

when comments_open() is called for a non-existant post (either a bad ID, or no ID passed and called from a non-single page), a PHP notice is caused. Ideally, plugins shouldn't be doing this, but a simple null check in comments_open() fixes the problem.

Attachments (1)

comment-template.diff (448 bytes) - added by willnorris 2 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 @willnorris2 years ago

oh, and the PHP Notice that is triggered is:

Notice: Trying to get property of non-object in .../wordpress/wp-includes/comment-template.php on line 776

comment:2 @SergeyBiryukov2 years ago

  • Component changed from Comments to Warnings/Notices
  • Version changed from trunk to 2.5

pings_open() has the similar code:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/comment-template.php#L789

Seems like the notice is appropriate in the case if a non-existant post, not sure if we should hide it. Related: ticket:17299:6.

Version 0, edited 2 years ago by SergeyBiryukov (next)

comment:3 @markoheijnen2 years ago

Maybe doing_it_wrong message?. A PHP notice isn't really telling something.

comment:4 @nacin15 months ago

  • Component changed from Warnings/Notices to Comments
Note: See TracTickets for help on using tickets.