WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 3 days ago

#23432 assigned enhancement

Review usage of target="_blank" in the admin

Reported by: theadityajain Owned by: rianrietveld
Milestone: 4.7 Priority: normal
Severity: normal Version: 3.2
Component: Administration Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

Some links in the Setting Pages (General, Discussion, Permalink) pages open in same window, which sometime can be awful.
While the users can press cmd/ctrl + click and click the link to open it in new tab but If the user does not open the link in new window, options (which are not saved) will be lost and one have to go through them again.
Also links in the Edit Profile page and all the links in the help tab open in new window except a few.(so it is possible that users may just click it thinking them to alike other links which open in new window)
So a consistency will be there and ux can be a little better.

Attachments (2)

23432.diff (5.5 KB) - added by theadityajain 4 years ago.
33303.patch (1.2 KB) - added by juhise 14 months ago.
patch file for user-edit.php

Download all attachments as: .zip

Change History (40)

@theadityajain
4 years ago

#3 @SergeyBiryukov
4 years ago

  • Keywords ui-focus added

#4 @toscho
4 years ago

  • Cc info@… added

#5 follow-up: @garthkoyle
3 years ago

  • Keywords close added
  • Resolution set to invalid
  • Status changed from new to closed
  • Version changed from 3.5.1 to trunk

I reviewed all the links in the Settings, Writing, Reading, Discussion, Media and Permalinks pages in BOTH 3.5.1 and 3.7-alpha-24822. No links were found to open in another tab/window so the links are consistent.

#6 @helen
3 years ago

  • Milestone Awaiting Review deleted

#7 in reply to: ↑ 5 @SergeyBiryukov
3 years ago

  • Keywords close removed
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version changed from trunk to 3.2

Replying to garthkoyle:

I reviewed all the links in the Settings, Writing, Reading, Discussion, Media and Permalinks pages in BOTH 3.5.1 and 3.7-alpha-24822. No links were found to open in another tab/window so the links are consistent.

As mentioned in the ticket description, the link on Profile screen opens in a new window, as well as almost all the links in Help tab.

We should probably review all the Codex links. Whether they should open in a new window or not, I guess it would make sense to be consistent.

#8 @SergeyBiryukov
3 years ago

  • Milestone set to Awaiting Review

#10 @DrewAPicture
20 months ago

  • Focuses accessibility added

#11 @joedolson
20 months ago

Mixed feelings on this question; in general, links should not open in new tabs/windows without informing the user, which would add a lot of noise to the screen. However, it is true that if a user opens the link in the same window without saving their settings, they can undo whatever work they were doing.

My vote would be in favor of using heartbeat to detect whether there are pending changes, or something to that effect, and throwing a warning if a user attempts to move to another page without saving changes, similar to what currently exists in post saving.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


14 months ago

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


14 months ago

#15 @davidakennedy
14 months ago

#31363 was marked as a duplicate.

#16 @davidakennedy
14 months ago

#31386 was marked as a duplicate.

#17 @DrewAPicture
14 months ago

#31386 was marked as a duplicate.

#18 @Ankit K Gupta
14 months ago

I think, Open the links in new tab is not good for point of user experience. If user want to open links in new tab then they have option to use Ctrl+click of keyboard.
If we give target="_blank" it means we are forcing user to open the link in new tab even if he doesn't want.
Also, it will increase the numbers of tabs in browser.

#19 @SergeyBiryukov
14 months ago

  • Summary changed from Links in Setting pages to open in new window to Review usage of target="_blank" in the admin

@juhise
14 months ago

patch file for user-edit.php

#20 @juhise
14 months ago

Added patch for making all codex link consistent throughout the Admin.

#21 @atomicjack
14 months ago

#33303 was marked as a duplicate.

#22 @netweb
13 months ago

Here's another, if your permalinks are not pretty you'll see a button next to the post permalink "Change Permalinks"
https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/post.php#L1292

1292:			$return .= '<span id="change-permalinks"><a href="options-permalink.php" class="button button-small" target="_blank">' . __('Change Permalinks') . "</a></span>\n";

#23 @swissspidy
9 months ago

#35244 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


6 months ago

#25 @rianrietveld
6 months ago

This ticket needs to be broken down in into multiple tickets with this ticket as a tracker.
The a11y team has set this as a goal for 4.6 but me probably need more time then that.
We also have to look at the "saving settings” issue and make a uniform decision about that.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


5 months ago

#27 @afercia
5 months ago

  • Milestone changed from Awaiting Review to Future Release
  • Severity changed from minor to normal

Discussed a bit during today's accessibility bug scrub, thinking this is something that should definitely be done but not sure we'll have time in this release cycle. Setting to future release for now.

Last edited 5 months ago by afercia (previous) (diff)

This ticket was mentioned in Slack in #core-editor by afercia. View the logs.


5 months ago

This ticket was mentioned in Slack in #core by mrwweb. View the logs.


4 months ago

#30 @afercia
3 months ago

#34727 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


5 weeks ago

#32 @rianrietveld
3 weeks ago

  • Owner set to rianrietveld
  • Status changed from reopened to assigned

#33 @rianrietveld
2 weeks ago

Investigated the use of target="_blank" in the admin today.

Almost all target="_blank" links are in the help-wrap at the top of almost each admin-view.
And if no permalink structure is set, a button Change permalink is shown with a target=_blank link to the set permalink page.

I left out the media and press-this for this review.

Most links can be changed easily by just removing the target.
On other pages an alert needs to be set for possible unsaved data when a user leaves, as done in the edit.php, but that can be done later.

The (old) link functionality is still in core, you can activate it with the the plugin Link Manager, which has 100,000+ active installs. This also has "_blank in the help-wrap.

The plan is to open new tickets per functionality (like users/comments/network) and make patches for those. We can discuss per ticket what needs to go and what can stay. But for the links in help: I think all blank can go.

A few questions:

  • Then there is the preview button. Should this open in a new window or in the same? I prefer stay with a visual warning.
  • Some functionality, like the menus and the old link functionality, gives the user the option to add a link target="_blank". Maybe we should reconsider this? Related to this is #36809

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


11 days ago

#35 @rianrietveld
11 days ago

  • Milestone changed from Future Release to 4.7

#36 @rianrietveld
7 days ago

Patches done so far:

  • #38145 Remove target="_blank" from help tab in serveral Admin screens
  • #38143 Remove target="_blank" from help tab option files for settings in the Admin
  • #38141 Remove target="_blank" from help tab custom-background/custom-header
  • #38140 Remove target="_blank" from help tab comment/comment-edit
  • #38159 Remove target="_blank" from help tab in Network screens in the Admin
Last edited 4 days ago by rianrietveld (previous) (diff)

This ticket was mentioned in Slack in #core by aaroncampbell. View the logs.


3 days ago

#38 @celloexpressions
3 days ago

In response to the questions in 33:

  • The preview button should open in a new tab by default since it's generally intended for back-and-forth (live preview is a better solution, which we'll have an option for eventually). Visual and/or screen-reader-text indicators of that would help. We have to remember that a very large number of users don't know how to open links in a new tab.
  • I would be in favor of removing the link target option for nav menus. However, we should probably wait until custom nav menu item properties are possible, so that a plugin could bring that functionality back. See #18584.
Note: See TracTickets for help on using tickets.