WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 6 weeks ago

#23432 reopened enhancement

Links in Setting pages to open in new window

Reported by: theadityajain Owned by:
Milestone: Awaiting Review Priority: normal
Severity: minor Version: 3.2
Component: Administration Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

Some links in the Setting Pages (General, Discussion, Permalink) pages open in same window, which sometime can be awful.
While the users can press cmd/ctrl + click and click the link to open it in new tab but If the user does not open the link in new window, options (which are not saved) will be lost and one have to go through them again.
Also links in the Edit Profile page and all the links in the help tab open in new window except a few.(so it is possible that users may just click it thinking them to alike other links which open in new window)
So a consistency will be there and ux can be a little better.

Attachments (1)

23432.diff (5.5 KB) - added by theadityajain 2 years ago.

Download all attachments as: .zip

Change History (13)

@theadityajain2 years ago

comment:3 @SergeyBiryukov2 years ago

  • Keywords ui-focus added

comment:4 @toscho2 years ago

  • Cc info@… added

comment:5 follow-up: @garthkoyle20 months ago

  • Keywords close added
  • Resolution set to invalid
  • Status changed from new to closed
  • Version changed from 3.5.1 to trunk

I reviewed all the links in the Settings, Writing, Reading, Discussion, Media and Permalinks pages in BOTH 3.5.1 and 3.7-alpha-24822. No links were found to open in another tab/window so the links are consistent.

comment:6 @helen20 months ago

  • Milestone Awaiting Review deleted

comment:7 in reply to: ↑ 5 @SergeyBiryukov16 months ago

  • Keywords close removed
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version changed from trunk to 3.2

Replying to garthkoyle:

I reviewed all the links in the Settings, Writing, Reading, Discussion, Media and Permalinks pages in BOTH 3.5.1 and 3.7-alpha-24822. No links were found to open in another tab/window so the links are consistent.

As mentioned in the ticket description, the link on Profile screen opens in a new window, as well as almost all the links in Help tab.

We should probably review all the Codex links. Whether they should open in a new window or not, I guess it would make sense to be consistent.

comment:8 @SergeyBiryukov16 months ago

  • Milestone set to Awaiting Review

comment:10 @DrewAPicture6 weeks ago

  • Focuses accessibility added

comment:11 @joedolson6 weeks ago

Mixed feelings on this question; in general, links should not open in new tabs/windows without informing the user, which would add a lot of noise to the screen. However, it is true that if a user opens the link in the same window without saving their settings, they can undo whatever work they were doing.

My vote would be in favor of using heartbeat to detect whether there are pending changes, or something to that effect, and throwing a warning if a user attempts to move to another page without saving changes, similar to what currently exists in post saving.

Note: See TracTickets for help on using tickets.