WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 9 months ago

Last modified 9 months ago

#23433 closed defect (bug) (fixed)

Custom background select needs a contextualized label

Reported by: xibe Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.5
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

In /themes.php?page=custom-background, the fixed/scroll selector uses the 'Attachment' label.

Problem is, that label name is also used for another type of attachment: files.

Ergo, translators might find themselves with an incorrect wording. In effect, the French translation displays "Fichier attaché" (attached file) instead of a more appropriate term.

I suggest turning the string into a contextualized one.

Another solution would be to change the wording altogether, for instance: "Behaviour when scrolling", with "Scroll along" and "Keep in place" as its options.

Hence, I submit both (hopefully correct) patches -- built against trunk for now, but the issue obviously exists in 3.5.

Attachments (2)

custom-background-selector-label-context.patch (678 bytes) - added by xibe 14 months ago.
Patch for context, against trunk.
custom-background-selector-label-change.patch (952 bytes) - added by xibe 14 months ago.
Patch for name change, against trunk.

Download all attachments as: .zip

Change History (6)

xibe14 months ago

Patch for context, against trunk.

xibe14 months ago

Patch for name change, against trunk.

comment:1 SergeyBiryukov14 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:2 SergeyBiryukov14 months ago

  • Keywords ui-focus added

comment:3 nacin9 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24621:

Context for 'Attachment' when referring to the background image attachment. props xibe, fixes #23433.

comment:4 nacin9 months ago

  • Keywords ui-focus removed

Context alone is sufficient for 3.6. Any UI changes should occur in a separate, non-i18n ticket.

Note: See TracTickets for help on using tickets.