WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 23 months ago

#23447 new defect (bug)

Explanation for "parent" dropdown missing for hierarchical custom taxonomies on edit tags admin screen

Reported by: F J Kaiser Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Text Changes Keywords: has-patch
Focuses: ui Cc:

Description

The "parent" dropdown/select field only gets displayed for hierarchical taxonomies. The explanation still only gets displayed for the "category" taxonomy.

Attachments (5)

23447_1.patch (1013 bytes) - added by F J Kaiser 2 years ago.
Removes the category check, as we already check for hierarchical. Removes part of the string to makes it more generic and force less update on translators.
23447.diff (1.9 KB) - added by raggedrobins 2 years ago.
23447.2.diff (2.0 KB) - added by DrewAPicture 2 years ago.
is_taxonomy_hierarchical on the help text change
23447.3.diff (2.0 KB) - added by raggedrobins 2 years ago.
23447.4.diff (3.1 KB) - added by DrewAPicture 2 years ago.

Download all attachments as: .zip

Change History (21)

@F J Kaiser2 years ago

Removes the category check, as we already check for hierarchical. Removes part of the string to makes it more generic and force less update on translators.

comment:1 @F J Kaiser2 years ago

  • Cc 24-7@… added
  • Keywords has-patch added
  • Version set to trunk

comment:2 @SergeyBiryukov2 years ago

  • Keywords ui-focus added; has-patch removed
  • Version changed from trunk to 3.0

Related: [13077]

23447_1.patch leaves a stray endif, causing a parse error.

The 'category' == $taxonomy check is consistent with the ones we have in some other places:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tags.php#L188
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tags.php#L299
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

The suggested string still references categories and doesn't sound completely generic. It just no longer explains the difference between a hierarchical and non-hierarchical taxonomy.

I guess we should either introduce some new generic strings, or leave the current UI as is, since removing the check in only one place would be inconsistent.

comment:3 follow-up: @helen2 years ago

Does one need the explanation for a custom taxonomy? And agree with SergeyBiryukov, just chopping the string like that isn't really making it any more generic, and I'm not sure we should.

comment:4 in reply to: ↑ 3 @F J Kaiser2 years ago

Replying to helen:

Does one need the explanation for a custom taxonomy?

I'm completely in for any change to this. My personal opinion is that it would be best to only make the string more generic and replace "Category" with either "Taxonomie" or the $taxonomy->label.

@Sergey Patch doesn't work because of forgotten line? Ups! Will surely deliver another patch and get this through to the end - if there's support for it.

comment:5 @helen2 years ago

A generic string that references the name of the taxonomy seems extremely difficult to pull off. Would love to see what a workable (and translatable) generic string could be, whether or not it includes the taxonomy name.

comment:6 @SergeyBiryukov2 years ago

See dd32's comment for why we're trying to avoid post type and taxonomy names in generic strings.

@raggedrobins2 years ago

comment:7 @raggedrobins2 years ago

  • Cc siobhan@… added

Added 23447.diff

Replace string with:

Assign a parent term to create a hierarchy. If you have the term Jazz, for example, that may be the parent of Bebop and Big Band.

This is more generic and uses the correct terminology of "term" as opposed to "Category".

(Thanks to @DrewAPicture for helping me with the patch).

comment:8 @DrewAPicture2 years ago

  • Cc xoodrew@… added

comment:9 @DrewAPicture2 years ago

  • Keywords has-patch added

comment:10 follow-ups: @helen2 years ago

  • Component changed from Taxonomy to Text Changes

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

comment:11 in reply to: ↑ 10 @DrewAPicture2 years ago

Replying to helen:

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

As @raggedrobbins noted on make:docs, there's quite a bit of text on this screen that could use a refresh.

Personally, I would champion a move away from button-holing ourselves into using specific taxonomy names and instead going with the more generic 'term' term. This dropdown label is one small example of a larger issue.

@DrewAPicture2 years ago

is_taxonomy_hierarchical on the help text change

@raggedrobins2 years ago

comment:12 in reply to: ↑ 10 @raggedrobins2 years ago

Replying to helen:

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

Added 23447.3 to edit sentence structure to:

Assign a parent term to create a hierarchy. The term Jazz, for example, would be the parent of Bebop and Big Band.

"Term" is how I always describe items within a taxonomy to users. There's not really any other adequate word to describe items within a taxonomy.

comment:13 follow-up: @SergeyBiryukov2 years ago

Note that edit-tag-form.php would also need a similar change:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

@DrewAPicture2 years ago

comment:14 in reply to: ↑ 13 @DrewAPicture2 years ago

Replying to SergeyBiryukov:

Note that edit-tag-form.php would also need a similar change:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

Done in 23447.4.diff

comment:15 @SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.6

comment:16 @ryan23 months ago

  • Milestone changed from 3.6 to Future Release
Note: See TracTickets for help on using tickets.