Explanation for "parent" dropdown missing for hierarchical custom taxonomies on edit tags admin screen

[F J Kaiser]

The "parent" dropdown/select field only gets displayed for hierarchical taxonomies. The explanation still only gets displayed for the "category" taxonomy.

[F J Kaiser]

Removes the category check, as we already check for hierarchical. Removes part of the string to makes it more generic and force less update on translators.

[SergeyBiryukov]

Related: [13077]

23447_1.patch​ leaves a stray endif, causing a parse error.

The 'category' == $taxonomy check is consistent with the ones we have in some other places:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tags.php#L188
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tags.php#L299
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

The suggested string still references categories and doesn't sound completely generic. It just no longer explains the difference between a hierarchical and non-hierarchical taxonomy.

I guess we should either introduce some new generic strings, or leave the current UI as is, since removing the check in only one place would be inconsistent.

[helen]

Does one need the explanation for a custom taxonomy? And agree with SergeyBiryukov, just chopping the string like that isn't really making it any more generic, and I'm not sure we should.

[F J Kaiser]

Replying to helen:

Does one need the explanation for a custom taxonomy?

I'm completely in for any change to this. My personal opinion is that it would be best to only make the string more generic and replace "Category" with either "Taxonomie" or the $taxonomy->label.

@Sergey Patch doesn't work because of forgotten line? Ups! Will surely deliver another patch and get this through to the end - if there's support for it.

[helen]

A generic string that references the name of the taxonomy seems extremely difficult to pull off. Would love to see what a workable (and translatable) generic string could be, whether or not it includes the taxonomy name.

[SergeyBiryukov]

See dd32's comment for why we're trying to avoid post type and taxonomy names in generic strings.

[raggedrobins]

Added 23447.diff

Replace string with:

Assign a parent term to create a hierarchy. If you have the term Jazz, for example, that may be the parent of Bebop and Big Band.

This is more generic and uses the correct terminology of "term" as opposed to "Category".

(Thanks to @DrewAPicture for helping me with the patch).

[helen]

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

[DrewAPicture]

Replying to helen:

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

As @raggedrobbins ​noted on make:docs, there's quite a bit of text on this screen that could use a refresh.

Personally, I would champion a move away from button-holing ourselves into using specific taxonomy names and instead going with the more generic 'term' term. This dropdown label is one small example of a larger issue.

[DrewAPicture]

is_taxonomy_hierarchical on the help text change

[raggedrobins]

Replying to helen:

First chunk of code probably needs to change if ( 'category' == $taxonomy ) to is_taxonomy_hierarchical( $taxonomy ).

The second sentence reads a little awkwardly to me. I'm also not sure about using the word "term", as to me it's a technical one, although I have no idea what the alternative could be. Is it used in help text elsewhere?

Added 23447.3 to edit sentence structure to:

Assign a parent term to create a hierarchy. The term Jazz, for example, would be the parent of Bebop and Big Band.

"Term" is how I always describe items within a taxonomy to users. There's not really any other adequate word to describe items within a taxonomy.

[SergeyBiryukov]

Note that edit-tag-form.php would also need a similar change:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

[DrewAPicture]

Replying to SergeyBiryukov:

Note that edit-tag-form.php would also need a similar change:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/edit-tag-form.php#L56

Done in 23447.4.diff​

[diddledani]

refresh against trunk@39850

[SergeyBiryukov]

• The help text should not really be changed, as it's only displayed for built-in taxonomies​, and I think it should stay that way. is_taxonomy_hierarchical() is redundant there.
• I think the existing text for categories should stay, as it explains the difference between categories and tags, which is helpful for novice users. "Term" is also a less clear concept in some languages than "category" or "tag", so the new generic text should only be displayed for custom taxonomies.

Any objections to 23447.6.diff​?

[SergeyBiryukov]

In 39895:

Taxonomy: Add an explanation for "Parent" dropdown for hierarchical custom taxonomies.

Props F J Kaiser, raggedrobins, DrewAPicture, diddledan, SergeyBiryukov.
Fixes #23447.