WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #23449, comment 7


Ignore:
Timestamp:
02/14/13 14:55:04 (17 months ago)
Author:
lessbloat
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23449, comment 7

    v1 v2  
    44> That means using closest() instead of parents(), changing `$( '.accordion-section' ).not( clicked ).removeClass( 'open' ); ` to `clicked.closest( '.accordion-container' ).find( '.accordion-section' ).not( clicked ).removeClass( 'open' );`, and changing all uses of id to class. 
    55 
    6 Good call.  23449.1.diff​ should take care of those items.  I just pulled the "Scroll up if on #accordion-section-title_tagline" code altogether as it's too specific to this one implementation, and to be honest, I don't think it improves the experience. 
     6Good call.  23449.1.diff​ should take care of those items.  I just pulled the "Scroll up if on #accordion-section-title_tagline" code altogether as it's too specific to this one implementation, and to be honest, I don't think it improves the experience in any way.