Changes between Version 1 and Version 2 of Ticket #23449, comment 7
- Timestamp:
- 02/14/2013 02:55:04 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #23449, comment 7
v1 v2 4 4 > That means using closest() instead of parents(), changing `$( '.accordion-section' ).not( clicked ).removeClass( 'open' ); ` to `clicked.closest( '.accordion-container' ).find( '.accordion-section' ).not( clicked ).removeClass( 'open' );`, and changing all uses of id to class. 5 5 6 Good call. 23449.1.diff should take care of those items. I just pulled the "Scroll up if on #accordion-section-title_tagline" code altogether as it's too specific to this one implementation, and to be honest, I don't think it improves the experience .6 Good call. 23449.1.diff should take care of those items. I just pulled the "Scroll up if on #accordion-section-title_tagline" code altogether as it's too specific to this one implementation, and to be honest, I don't think it improves the experience in any way.