WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 3 months ago

#23482 reopened defect (bug)

Fix improper use of comment_exists() in some importers

Reported by: SergeyBiryukov Owned by: maxpagels
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Import Keywords: has-patch, needs-testing, bulk-reopened
Focuses: Cc:

Attachments (7)

23482.patch (1.3 KB) - added by maxpagels 4 years ago.
Patch for DotClear Importer
23482.2.patch (1.2 KB) - added by maxpagels 4 years ago.
Patch for TextPattern Importer.
23482.3.patch (1.4 KB) - added by maxpagels 4 years ago.
Patch for TextPattern Importer (fixed comments).
23482.4.patch (1.5 KB) - added by maxpagels 4 years ago.
Patch for DotClear Importer (comments fixed).
23482.5.patch (1.4 KB) - added by maxpagels 4 years ago.
Fixed indentation of comments (TextPattern Importer).
23482.6.patch (1.5 KB) - added by maxpagels 4 years ago.
Fixed indentation of comments (Dotclear Importer).
23482.7.patch (1.4 KB) - added by maxpagels 4 years ago.
Fix for comment indentation (Texpattern Importer).

Download all attachments as: .zip

Change History (15)

#1 @chriscct7
4 years ago

  • Keywords needs-patch good-first-bug added

@maxpagels
4 years ago

Patch for DotClear Importer

@maxpagels
4 years ago

Patch for TextPattern Importer.

#2 @maxpagels
4 years ago

Regarding the above patches, a more elegant solution may well exist, but this should work.

@maxpagels
4 years ago

Patch for TextPattern Importer (fixed comments).

@maxpagels
4 years ago

Patch for DotClear Importer (comments fixed).

#3 @obenland
4 years ago

  • Owner set to maxpagels
  • Status changed from new to assigned

#4 @maxpagels
4 years ago

  • Keywords has-patch needs-testing added; needs-patch good-first-bug removed
Version 0, edited 4 years ago by maxpagels (next)

#5 @maxpagels
4 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

@maxpagels
4 years ago

Fixed indentation of comments (TextPattern Importer).

@maxpagels
4 years ago

Fixed indentation of comments (Dotclear Importer).

@maxpagels
4 years ago

Fix for comment indentation (Texpattern Importer).

#6 @maxpagels
4 years ago

  • Keywords has-patch needs-testing added; needs-patch removed
Last edited 4 years ago by maxpagels (previous) (diff)

#7 @iseulde
5 months ago

  • Milestone WordPress.org deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

This ticket has not seen any activity in over *two* years, so I'm closing it as "wontfix".

The ticket may lack decisiveness, may have become irrelevant, or may not have gathered enough interest.

If you think this ticket does deserve some attention again, feel free to reopen.

For bugs, it would be great if you could provide updated steps to reproduce against the latest version of WordPress (5.0.2 at the time of writing). Remember images or a video can be superior to explain a problem. At the very least, quickly test again to make sure the bug still exists.

If it’s an enhancement or feature, some extra motivation may help.

Thank you for your contributions to WordPress! <3

#8 @JeffPaul
3 months ago

  • Keywords bulk-reopened added
  • Milestone set to Awaiting Review
  • Resolution wontfix deleted
  • Status changed from closed to reopened

A decision was made to reopen tickets that were closed in the bulk edit that this ticket was affected by. This ticket is being placed back into the Awaiting Review milestone so it can be individually evaluated and verified to determine if it is still relevant/valid or reproducible.

Note: See TracTickets for help on using tickets.