WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Last modified 6 years ago

#23482 assigned defect (bug)

Fix improper use of comment_exists() in some importers

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: maxpagels's profile maxpagels
Milestone: Priority: normal
Severity: normal Version:
Component: Import Keywords: has-patch needs-testing
Focuses: Cc:

Description

Background: #20494

DotClear Importer and TextPattern Importer treat the returned comment post ID as a comment ID:
​http://plugins.trac.wordpress.org/browser/dotclear-importer/trunk/dotclear-importer.php#L416
​http://plugins.trac.wordpress.org/browser/textpattern-importer/trunk/textpattern-importer.php#L429

Attachments (7)

23482.patch​ (1.3 KB) - added by maxpagels 10 years ago.
Patch for DotClear Importer
23482.2.patch​ (1.2 KB) - added by maxpagels 10 years ago.
Patch for TextPattern Importer.
23482.3.patch​ (1.4 KB) - added by maxpagels 10 years ago.
Patch for TextPattern Importer (fixed comments).
23482.4.patch​ (1.5 KB) - added by maxpagels 10 years ago.
Patch for DotClear Importer (comments fixed).
23482.5.patch​ (1.4 KB) - added by maxpagels 10 years ago.
Fixed indentation of comments (TextPattern Importer).
23482.6.patch​ (1.5 KB) - added by maxpagels 10 years ago.
Fixed indentation of comments (Dotclear Importer).
23482.7.patch​ (1.4 KB) - added by maxpagels 10 years ago.
Fix for comment indentation (Texpattern Importer).

Download all attachments as: .zip

Change History (13)

#1 @chriscct7
10 years ago

  • Keywords needs-patch good-first-bug added

@maxpagels
10 years ago

Patch for DotClear Importer

@maxpagels
10 years ago

Patch for TextPattern Importer.

#2 @maxpagels
10 years ago

Regarding the above patches, a more elegant solution may well exist, but this should work.

@maxpagels
10 years ago

Patch for TextPattern Importer (fixed comments).

@maxpagels
10 years ago

Patch for DotClear Importer (comments fixed).

#3 @obenland
10 years ago

  • Owner set to maxpagels
  • Status changed from new to assigned

#4 @maxpagels
10 years ago

  • Keywords has-patch needs-testing added; needs-patch good-first-bug removed

Will update the patches with proper indenting (sorry, didn't catch it the first time.)

Last edited 10 years ago by maxpagels (previous) (diff)

#5 @maxpagels
10 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

@maxpagels
10 years ago

Fixed indentation of comments (TextPattern Importer).

@maxpagels
10 years ago

Fixed indentation of comments (Dotclear Importer).

@maxpagels
10 years ago

Fix for comment indentation (Texpattern Importer).

#6 @maxpagels
10 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Indents finally fixed, sorry for the delay. Looks and works fine as far as I can tell, though some additional testing would be appreciated.

Version 0, edited 10 years ago by maxpagels (next)
Note: See TracTickets for help on using tickets.