WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 8 months ago

Last modified 8 months ago

#23486 closed enhancement (fixed)

Deprecate/remove custom-fields.js and categories.js

Reported by: ocean90 Owned by: nacin
Milestone: 3.6.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

admin-categories aka wp-admin/js/categories.js is unused since 3.1.

admin-custom-fields aka wp-admin/js/custom-fields.js is unused since 2.5.

Attachments (2)

23486.patch (5.3 KB) - added by ocean90 14 months ago.
23486.old-files.diff (471 bytes) - added by duck_ 8 months ago.

Download all attachments as: .zip

Change History (13)

ocean9014 months ago

comment:1 nacin14 months ago

Only instances in the plugin directory of either are:

plugins/zelist/admin/link-categories.php:49:wp_enqueue_script('admin-categories');
plugins/zelist-directory/wp-admin/categories.php:128:wp_enqueue_script( 'admin-categories' );

Both of which are straight copies of the link-categories.php and categories.php wp-admin files.

comment:2 nacin14 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23446:

Remove unused admin-categories and admin-custom-fields JavaScript files. props ocean90. fixes #23486.

comment:3 SergeyBiryukov14 months ago

  • Keywords 2nd-opinion removed
  • Milestone changed from Awaiting Review to 3.6

comment:4 SergeyBiryukov14 months ago

  • Component changed from General to Administration

comment:5 pat@…8 months ago

These files have been left in the zip package as 0-byte files which results in a copy error when unzipping the package using PHPs ZipArchive library. They should be removed from the zip archive if they have been deprecated/removed.

comment:6 pat@…8 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 nacin8 months ago

In 25013:

Remove zero-byte files that were meant to be deleted in [23446]. see #23486.

comment:8 nacin8 months ago

In 25014:

Remove zero-byte files that were meant to be deleted in [23446]. see #23486.

Merges [25013] to the 3.6 branch.

comment:9 SergeyBiryukov8 months ago

  • Milestone changed from 3.6 to 3.6.1
  • Resolution set to fixed
  • Status changed from reopened to closed

duck_8 months ago

comment:10 duck_8 months ago

[25013] missed out adding the files to $_old_files in trunk, see 23486.old-files.diff.

comment:11 duck_8 months ago

In 25019:

Add javascript files deleted in [25013] to $_old_files. See #23486.

Note: See TracTickets for help on using tickets.