WordPress.org

Make WordPress Core

Changes between Initial Version and Version 2 of Ticket #23498


Ignore:
Timestamp:
02/18/13 18:53:35 (14 months ago)
Author:
SergeyBiryukov
Comment:

Related: #9165, #9902

Introduced in [15620], previously user_login field was used for comparison.

The parameter itself was added in [2632]. We should probably deprecate it in favor of exclude (#9902).

Still, fixing it makes sense to me. The description refers to "the 'admin' user that is installed by default":
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/author-template.php#L246

Codex specifically refers to the login: "Exclude the 'admin' (login is admin) account from the list":
http://codex.wordpress.org/Function_Reference/wp_list_authors#Parameters

The default username, however, can be manually picked now (#10396).

I guess we have the following options to fix this:

  • 'admin' == $author->user_login.
  • 1 == $author->ID (from #9165).
  • get_option('admin_email') == $author->user_email (from comment:1).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23498

    • Property Cc knut@… added
    • Property Keywords has-patch removed
    • Property Version changed from 3.5.1 to 3.1
  • Ticket #23498 – Description

    initial v2  
    11Line 293 of author-template.php should be changed from: 
    2  
     2{{{ 
    33if ( $exclude_admin && 'admin' == $author->display_name ) 
    4  
     4}}} 
    55to: 
    6  
     6{{{ 
    77if ( $exclude_admin && 'admin' == $author->user_login ) 
    8  
     8}}} 
    99Thanks.