WordPress.org

Make WordPress Core

Changes between Version 1 and Version 21 of Ticket #23503


Ignore:
Timestamp:
06/26/13 21:12:36 (13 months ago)
Author:
johnbillion
Comment:

Point #3 in this ticket is also no longer relevant due to #24452. Patch for the remaining issue coming up.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23503

    • Property Keywords has-patch added; needs-patch removed
    • Property Cc xoodrew@… added
  • Ticket #23503 – Description

    v1 v21  
    10102. ~~[23449] introduced Edit screen UI for post formats. There's now a "Standard" tab above the post title. In Russian, "post" is feminine and "format" is masculine, so seeing "Standard" adjective without the "format" word next to it is confusing. I guess the tab needs a separate context.~~ Fixed in [23843]. 
    1111 
    12 3. [23843] introduced a couple of issues: 
    13  1. `ucfirst( sprintf( __( '%s Post' ), $slug ) )`: [[BR]] 
    14   http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L186 
    15   1. `'%s Post'` is not localizable, see [comment:ticket:17609:3 dd32's comment] in #17609. 
    16   2. `ucfirst()` doesn't always work correctly for UTF-8 characters, it depends on PHP locale. 
    17  We should use actual labels instead of just putting post format slugs into a generic string. 
    18  1. i18n is missing in line 397: [[BR]] 
    19  http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L397 
     123. ~~[23843] introduced a couple of issues:~~ 
     13 1. ~~`ucfirst( sprintf( __( '%s Post' ), $slug ) )`: [[BR]] 
     14  http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L186~~ 
     15  1. ~~`'%s Post'` is not localizable, see [comment:ticket:17609:3 dd32's comment] in #17609.~~ 
     16  2. ~~`ucfirst()` doesn't always work correctly for UTF-8 characters, it depends on PHP locale.~~ 
     17 ~~We should use actual labels instead of just putting post format slugs into a generic string.~~ 
     18 1. ~~i18n is missing in line 397: [[BR]] 
     19 http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L397~~ No longer relevant; see #24452.