WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 10 months ago

#23503 closed defect (bug)

Post Formats: i18n issues — at Version 1

Reported by: SergeyBiryukov Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: I18N Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

  1. Most of the time, we refer to the "Standard" post format with the appropriate context:
    http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/class-wp-posts-list-table.php#L1013
    http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/press-this.php#L480
    http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/post.php#L5325

In a couple of places, however, the context is missing:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/meta-boxes.php#L318
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/options-writing.php#L90

  1. [23449] introduced Edit screen UI for post formats. There's now a "Standard" tab above the post title. In Russian, "post" is feminine and "format" is masculine, so seeing "Standard" adjective without the "format" word next to it is confusing. I guess the tab needs a separate context. Fixed in [23843].
  1. [23843] introduced a couple of issues:
    1. ucfirst( sprintf( __( '%s Post' ), $slug ) ):
      http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L186
      1. '%s Post' is not localizable, see dd32's comment in #17609.
      2. ucfirst() doesn't always work correctly for UTF-8 characters, it depends on PHP locale.
      We should use actual labels instead of just putting post format slugs into a generic string.
    2. i18n is missing in line 397:
      http://core.trac.wordpress.org/browser/trunk/wp-admin/edit-form-advanced.php?rev=23868#L397

Change History (3)

SergeyBiryukov14 months ago

comment:1 SergeyBiryukov13 months ago

  • Description modified (diff)
  • Keywords needs-patch added; has-patch removed
  • Summary changed from Standard post format needs more contexts to Post Formats: i18n issues

johnbillion13 months ago

Note: See TracTickets for help on using tickets.