WordPress.org

Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#23511 closed defect (bug) (fixed)

Twenty Thirteen: twentythirteen_aside_date() breaks oEmbed in some cases

Reported by: PotterSys Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Trying out Twenty Thirteen, I found some oEmbed elements on 'aside' posts were displayed as plain text (specifically those where the URL was at the end)

Digging around, I found twentythirteen_aside_date adds the date just right to the content (without a new line); and the function was added before oEmbed processing. The quickest solution I found was add the new line before executing twentythirteen_entry_date

Attachments (2)

23511.diff (524 bytes) - added by PotterSys 17 months ago.
Quick fix to oEmbed not being shown on asides
23511.1.diff (592 bytes) - added by obenland 17 months ago.
Bump priority to append it after embeds.

Download all attachments as: .zip

Change History (9)

PotterSys17 months ago

Quick fix to oEmbed not being shown on asides

comment:1 helen17 months ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 3.6

comment:2 SergeyBiryukov17 months ago

  • Keywords has-patch added

comment:3 follow-up: lancewillett17 months ago

PotterSys, thanks for the ticket and patch.

Testing note: we should try to change the priority of the filter instead of adding the \n. The newline breaks the display of the datestamp for asides, and isn't really needed.

obenland17 months ago

Bump priority to append it after embeds.

comment:4 in reply to: ↑ 3 PotterSys17 months ago

lancewillett:

Testing note: we should try to change the priority of the filter instead of adding the \n. The newline breaks the display of the datestamp for asides, and isn't really needed.

As the default value for priority in add_filter() is 10, I thought changing that value could break something else. However, the patch submitted by obenland fixes the bug by changing the priority

comment:5 lancewillett17 months ago

  • Keywords commit added

comment:6 lancewillett17 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23461:

Twenty Thirteen: bump priority for twentythirteen_aside_date() to add date output after embeds. Fixes #23511, props obenland.

comment:7 lancewillett17 months ago

In 23462:

Twenty Thirteen: fix comment form layout for inline replies in wide viewports. Fixes #23524, props SriniG and obenland.

(Also fix an extra space that crept into r23461, see #23511.)

Note: See TracTickets for help on using tickets.