Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#23511 closed defect (bug) (fixed)

Twenty Thirteen: twentythirteen_aside_date() breaks oEmbed in some cases

Reported by: pottersys's profile PotterSys Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Trying out Twenty Thirteen, I found some oEmbed elements on 'aside' posts were displayed as plain text (specifically those where the URL was at the end)

Digging around, I found twentythirteen_aside_date adds the date just right to the content (without a new line); and the function was added before oEmbed processing. The quickest solution I found was add the new line before executing twentythirteen_entry_date

Attachments (2)

23511.diff (524 bytes) - added by PotterSys 11 years ago.
Quick fix to oEmbed not being shown on asides
23511.1.diff (592 bytes) - added by obenland 11 years ago.
Bump priority to append it after embeds.

Download all attachments as: .zip

Change History (9)

@PotterSys
11 years ago

Quick fix to oEmbed not being shown on asides

#1 @helen
11 years ago

  • Component changed from Themes to Bundled Theme
  • Milestone changed from Awaiting Review to 3.6

#2 @SergeyBiryukov
11 years ago

  • Keywords has-patch added

#3 follow-up: @lancewillett
11 years ago

PotterSys, thanks for the ticket and patch.

Testing note: we should try to change the priority of the filter instead of adding the \n. The newline breaks the display of the datestamp for asides, and isn't really needed.

@obenland
11 years ago

Bump priority to append it after embeds.

#4 in reply to: ↑ 3 @PotterSys
11 years ago

lancewillett:

Testing note: we should try to change the priority of the filter instead of adding the \n. The newline breaks the display of the datestamp for asides, and isn't really needed.

As the default value for priority in add_filter() is 10, I thought changing that value could break something else. However, the patch submitted by obenland fixes the bug by changing the priority

#5 @lancewillett
11 years ago

  • Keywords commit added

#6 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23461:

Twenty Thirteen: bump priority for twentythirteen_aside_date() to add date output after embeds. Fixes #23511, props obenland.

#7 @lancewillett
11 years ago

In 23462:

Twenty Thirteen: fix comment form layout for inline replies in wide viewports. Fixes #23524, props SriniG and obenland.

(Also fix an extra space that crept into r23461, see #23511.)

Note: See TracTickets for help on using tickets.