Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#23514 closed defect (bug) (fixed)

Twenty Thirteen: Adjust line-height and font-size to be consistently applied across elements

Reported by: chriswallace's profile chriswallace Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Within post content, there is no line-height being applied to some elements like UL and OL lists. I've removed overly-specific font-size/line-height declarations for certain elements and applied a base font size and line height to the body element.

Attachments (3)

line-height.png (42.8 KB) - added by chriswallace 12 years ago.
Example of inconsistent line height.
fontsize.patch (848 bytes) - added by chriswallace 12 years ago.
patch for Twenty Thirteen style.css file.
23514.diff (1.0 KB) - added by obenland 12 years ago.

Download all attachments as: .zip

Change History (15)

#1 @SergeyBiryukov
12 years ago

  • Summary changed from Adjust line-height and font-size to be consistently applied across elements to Twenty Thirteen: Adjust line-height and font-size to be consistently applied across elements

#2 @lancewillett
12 years ago

  • Milestone changed from Awaiting Review to 3.6

Thanks for the report, Chris -- can you help us out by adding a few screenshots so we can see the problem visually and be on the same page?

@chriswallace
12 years ago

Example of inconsistent line height.

#3 follow-up: @SergeyBiryukov
12 years ago

#23538 was marked as a duplicate.

#4 @obenland
12 years ago

I think line-height-wise the patch is on a good way. How about resetting h1-h6 to line-height 1, so they don't grow too big?

We shouldn't adjust the font-size though, it is intended to be 16px globally with certain elements (meta links etc.) being 14px.

#5 in reply to: ↑ 3 ; follow-up: @chriswallace
12 years ago

  • Cc chriswallace added

Replying to SergeyBiryukov:

#23538 was marked as a duplicate.

I'm not sure this was a duplicate necessarily. I think that refers specifically to the bottom margin for lists, which is similar but not exactly the same, though I think we can probably take care of that issue as well.

#6 in reply to: ↑ 5 @SergeyBiryukov
12 years ago

Replying to chriswallace:

I'm not sure this was a duplicate necessarily.

Indeed. I've reopened #23538.

@chriswallace
12 years ago

patch for Twenty Thirteen style.css file.

#7 @chriswallace
12 years ago

Alrighty, I made some adjustments and made a minor adjustment for h1 line height. I think 1.5 is good for h2-h6 elements but 1.3 looks good for h1 elements.You can see an example of this adjustment here: http://cl.ly/image/302C3y0g0d1e

Let me know if you see any other issues or modifications I should make.

#8 follow-up: @obenland
12 years ago

After some testing, let's do 1.3 for h1-h6. We can also get rid of the .comment-author .fn selector on line 3088.

What specifically do we gain by defining a font-size on body?

#9 in reply to: ↑ 8 @chriswallace
12 years ago

Replying to obenland:

After some testing, let's do 1.3 for h1-h6. We can also get rid of the .comment-author .fn selector on line 3088.

What specifically do we gain by defining a font-size on body?

Good question. We can remove that declaration if 16px is our default as well as font-size: 100%; on the html element. I will update the patch this evening.

#10 follow-up: @chriswallace
12 years ago

Just wondering, are we setting font-size: 100% because of this issue? http://kyleschaeffer.com/user-experience/css-font-size-em-vs-px-vs-pt-vs/

@obenland
12 years ago

#11 in reply to: ↑ 10 @obenland
12 years ago

  • Keywords commit added; dev-feedback removed

Replying to chriswallace:

Just wondering, are we setting font-size: 100% because of this issue? http://kyleschaeffer.com/user-experience/css-font-size-em-vs-px-vs-pt-vs/

Maybe not this article in particular, but the general idea behind it, yes.

#12 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23497:

Twenty Thirteen: adjust line-height to be consistently applied across elements, props chriswallace and obenland. Fixes #23514.

Note: See TracTickets for help on using tickets.