WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#23516 closed defect (bug) (fixed)

Current 3.6 trunk wont install

Reported by: csixty4 Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: major Version: 3.6
Component: Upgrade/Install Keywords: dev-feedback
Focuses: Cc:
PR Number:

Description

Setup for a fresh WP 3.6 install using current trunk crashes with an empty white box on a gray background.

[18-Feb-2013 22:53:56] PHP Fatal error:  Call to undefined function wp_kses_normalize_entities() in /Applications/MAMP/htdocs/wp36/wp-includes/formatting.php on line 2797
[18-Feb-2013 22:53:56] PHP Stack trace:
[18-Feb-2013 22:53:56] PHP   1. {main}() /Applications/MAMP/htdocs/wp36/wp-admin/setup-config.php:0
[18-Feb-2013 22:53:56] PHP   2. setup_config_display_header() /Applications/MAMP/htdocs/wp36/wp-admin/setup-config.php:109
[18-Feb-2013 22:53:56] PHP   3. esc_url() /Applications/MAMP/htdocs/wp36/wp-admin/setup-config.php:103

Attachments (2)

23516.diff (496 bytes) - added by csixty4 7 years ago.
Patch assuming it's ok to load kses.php at this point
23516.1.diff (580 bytes) - added by JustinSainton 7 years ago.

Download all attachments as: .zip

Change History (9)

@csixty4
7 years ago

Patch assuming it's ok to load kses.php at this point

#1 @SergeyBiryukov
7 years ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to 3.6
  • Severity changed from normal to major

Broken in [23413]. We don't include kses.php in setup-config.php:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/setup-config.php#L58

Should we revert to esc_attr_e() there, or perhaps include kses.php?

#2 @nacin
7 years ago

I think I am okay with esc_attr here.

#3 @JustinSainton
7 years ago

23516.1.diff replaces esc_url() with esc_attr().

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23455:

Revert to esc_attr_e() in setup-config.php to prevent a fatal error.
kses.php is not loaded at this point, so esc_url() cannot be used.

props csixty4, JustinSainton.
fixes #23516. see #23334.

#5 follow-up: @obenland
7 years ago

Shouldn't it still be echo esc_attr() then, rather than using a translation function with esc_attr_e()? Or was that not part of the original ticket?

#6 @kraftbj
7 years ago

#23518 was marked as a duplicate.

#7 in reply to: ↑ 5 @SergeyBiryukov
7 years ago

Replying to obenland:

Shouldn't it still be echo esc_attr() then, rather than using a translation function with esc_attr_e()? Or was that not part of the original ticket?

The intention of #23334 was to use esc_url() where possible, while keeping the links translatable.

Note: See TracTickets for help on using tickets.