Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#23524 closed defect (bug) (fixed)

Twenty Thirteen: Comment reply form for replies via the 'Reply' link shrinks in wider viewports

Reported by: srinig's profile SriniG Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Comment reply form for replies to an existing comment via the 'Reply' link shrinks sideways in viewports wider than 1000px. And this happens only when there is an active sidebar. This condition does not occur in screen widths less than 1000px (where the sidebar falls down gracefully), or if there is no sidebar. Tested with Chromium Version 24.0.1312.56 and Firefox 18.0.2 in Ubuntu 12.04.

Attachments (3)

twentythirteen-page-with-comments-reply.png (44.8 KB) - added by SriniG 11 years ago.
comment-reply-form-fix.patch (483 bytes) - added by SriniG 11 years ago.
Patch that fixes the bug.
23524-fix.patch (415 bytes) - added by SriniG 11 years ago.
Per comment-3 by obenland.

Download all attachments as: .zip

Change History (9)

@SriniG
11 years ago

Patch that fixes the bug.

#1 @SriniG
11 years ago

  • Keywords has-patch needs-testing added

#2 @lancewillett
11 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 follow-up: @obenland
11 years ago

  • Keywords needs-testing removed

We already have a fix for that in place (line 2309), the selector is just too weak. Adding #respond before #commentform does the trick.

Did I mention I wished there were classes in all of comment_form()?

#4 in reply to: ↑ 3 @SriniG
11 years ago

Yes, adding a #respond before #commentform in line 2309 solves it! Thanks.

@SriniG
11 years ago

Per comment-3 by obenland.

#5 @lancewillett
11 years ago

  • Keywords commit added

#6 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23462:

Twenty Thirteen: fix comment form layout for inline replies in wide viewports. Fixes #23524, props SriniG and obenland.

(Also fix an extra space that crept into r23461, see #23511.)

Note: See TracTickets for help on using tickets.