WordPress.org

Make WordPress Core

#23536 closed defect (bug) (fixed)

Twenty Thirteen: Hover/focus style for buttons

Reported by: johnbillion Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Buttons in Twenty Thirteen (eg. the "Post Comment" button) don't have a hover or focus style.

I played around with using the same light orange colour for the hover style that's used on links (#ea9629), but it's quite an abrupt change of colour for a hover. Maybe we could use an orange somewhere between #d94412 and #ea9629.

Attachments (2)

23536.patch (3.3 KB) - added by lancewillett 14 months ago.
Patch from joen for hover/focus styles
23536.1.diff (3.2 KB) - added by obenland 14 months ago.
Based off of Joen's work: a bit less intrusive, a bit more CSS style guideline conform

Download all attachments as: .zip

Change History (6)

comment:1 lancewillett14 months ago

  • Keywords needs-patch dev-feedback added
  • Milestone changed from Awaiting Review to 3.6
  • Type changed from enhancement to defect (bug)

lancewillett14 months ago

Patch from joen for hover/focus styles

comment:2 lancewillett14 months ago

  • Keywords has-patch needs-testing added; needs-patch dev-feedback removed

Added patch from joen -- needs testing.

Note: button / input styles might need better consolidation in the stylesheet. They are in two places right now.

obenland14 months ago

Based off of Joen's work: a bit less intrusive, a bit more CSS style guideline conform

comment:3 lancewillett14 months ago

  • Keywords commit added; needs-testing removed

New patch tests out well, thank you.

comment:4 lancewillett14 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23470:

Twenty Thirteen: add hover/focus style for buttons and organize button and input selectors a bit for a better cascade. Fixes #23536, props obenland.

Note: See TracTickets for help on using tickets.