WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#23540 closed enhancement (fixed)

Network Update screen text

Reported by: jenmylo Owned by: ryan
Milestone: 3.6 Priority: low
Severity: minor Version:
Component: Text Changes Keywords: has-patch commit
Focuses: Cc:

Description

At /wp-admin/network/upgrade.php, the text prompt is:

You can update all the sites on your network through this page. It works by calling the update script of each site automatically. Hit the link below to update.

It's confusing because it is worded more like a core update notice than the database update notice, but @nacin says this is db, not code. Should modify text to be consistent with the wording used on single site db update notice.

Also, it says hit the link below, but it's actually a button, so the word "link" should become "button" for clarity.

Screenshot attached.

Attachments (4)

Screen shot 2013-02-19 at 2.47.25 PM.png (19.4 KB) - added by jenmylo 8 years ago.
Screenshot of wp-admin/network/upgrade.php
23540.diff (1006 bytes) - added by DrewAPicture 8 years ago.
23540.2.diff (1010 bytes) - added by DrewAPicture 8 years ago.
23540.3.diff (4.4 KB) - added by DrewAPicture 8 years ago.

Download all attachments as: .zip

Change History (13)

@jenmylo
8 years ago

Screenshot of wp-admin/network/upgrade.php

@DrewAPicture
8 years ago

#1 @DrewAPicture
8 years ago

  • Component changed from Network Admin to Text Changes
  • Keywords has-patch added; needs-patch removed

23540.diff takes a stab at it:

Database Update Required

WordPress has been updated! Before we send you on your way, we need to individually update the sites in your network.

The update process may take a little while, so please be patient.

[ Update Network ]

#2 follow-up: @nacin
8 years ago

I'd suggest we use "database upgrade", not "database update". We have, for a long while, said "update" when referring to code, and "upgrade" when referring to the database. Note upgrade.php (for a single-site upgrade).

@DrewAPicture
8 years ago

#3 in reply to: ↑ 2 @DrewAPicture
8 years ago

  • Cc xoodrew@… added

Replying to nacin:

I'd suggest we use "database upgrade", not "database update".

Done in 23540.2.diff:

Database Upgrade Required

WordPress has been updated! Before we send you on your way, we need to individually upgrade the sites in your network.

The upgrade process may take a little while, so please be patient.

[ Upgrade Network ]

#4 @DrewAPicture
8 years ago

23540.3.diff updates all references to the former 'Update Network' button as well as the screen titles.

@DrewAPicture
8 years ago

#5 @SergeyBiryukov
8 years ago

  • Keywords commit added

#6 @ryan
8 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 23619:

Call them network upgrades rather than network updates to better indicate that they are DB upgrades rather than code/file upgrades.

Improve the contextual help for the Network Upgrade screen.

Props DrewAPicture
fixes #23540

#7 @johnjamesjacoby
8 years ago

Wish I had seen this ticket to chime in sooner.

This is a confusing change after years of avoiding using "Upgrade" in core and plugins. It implies:

  • That a "downgrade" is possible (which isn't something we currently offer.)
  • That it's optional (when it's usually necessary)
  • That it's a reward (upgrading to first class, upgrading your rental car, upgrading your cable package)

I don't care strongly enough to lobby for a revert, but it was nice to have the strict verbiage rule to lean on.

#8 @nacin
8 years ago

We do have a strict verbiage rule. "update" = code, "upgrade" = DB.

#9 @nacin
8 years ago

In 25191:

Hide 'Database Upgrade Required' on admin/network/upgrade.php when you are not being asked to upgrade, to prevent confusion.

props duck_.
see #24845. see #23540.

Note: See TracTickets for help on using tickets.