Opened 12 years ago
Closed 12 years ago
#23551 closed defect (bug) (fixed)
Twenty Thirteen: add Editor styles
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
Add styles for the TinyMCE visual editor.
Note: see #22499 for loading the Google fonts in the editor stylesheet in Twenty Thirteen.
Attachments (5)
Change History (21)
#5
@
12 years ago
Noting also Editor Styles will need RTL version in css/editor-style-rtl.css
, see also #23550.
#6
@
12 years ago
.4 patch: update comment blocks (add a few periods, remove extra space before closing braces) and update CSS comment style to match main stylesheet.
#8
in reply to:
↑ 7
@
12 years ago
Replying to azaozz:
Would there be a visible indication of the theme's width in the editor?
We didn't do it in older default themes -- should we add it? I personally like it without.
#9
@
12 years ago
It's always been a bit weird that there is a well defined box where to type but the text wraps in the middle of it. On the other hand most users are used to that by now.
#10
@
12 years ago
- Cc kovshenin added
@kovshenin Do you have an opinion on the shaded background colors to show an idea of the content width?
#11
@
12 years ago
I don't have a strong opinion on this. I can usually figure out the content width right after typing in the first line, and in DFW the dotted border is very helpful too. I also don't think it will hurt, even if people are used to it.
#13
@
12 years ago
@azaozz: On the other hand most users are used to that by now
That wrap still feels a little weird. I think I like the very light grey background.
Though if it's loaded by the theme, it will feel strange to them if/when they switch themes and it goes away.
#14
@
12 years ago
As discussed in today's Twenty Thirteen office hours log -- another suggestion is to use a dotted gray line on the right side, similar style to the DFW interface.
Sounds like most people voted to leave it out entirely, though.
Used the Layout Test from the Theme Unit Test to verify the editor styles. There a still some issues with the
kdb
andtt
tags though.