Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#23551 closed defect (bug) (fixed)

Twenty Thirteen: add Editor styles

Reported by: lancewillett's profile lancewillett Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by lancewillett)

Add styles for the TinyMCE visual editor.

Note: see #22499 for loading the Google fonts in the editor stylesheet in Twenty Thirteen.

Attachments (5)

23551.patch (6.8 KB) - added by Frank Klein 12 years ago.
23551.2.patch (7.3 KB) - added by Frank Klein 12 years ago.
23551.3.diff (7.6 KB) - added by obenland 12 years ago.
23551.4.diff (7.8 KB) - added by lancewillett 12 years ago.
editor-body.png (12.9 KB) - added by azaozz 12 years ago.

Download all attachments as: .zip

Change History (21)

#1 @lancewillett
12 years ago

  • Description modified (diff)

@Frank Klein
12 years ago

#2 @Frank Klein
12 years ago

  • Keywords has-patch added; needs-patch removed

Used the Layout Test from the Theme Unit Test to verify the editor styles. There a still some issues with the kdb and tt tags though.

#3 @Frank Klein
12 years ago

  • Cc contact@… added

#4 @Frank Klein
12 years ago

Added caption styles.

@obenland
12 years ago

#5 @lancewillett
12 years ago

Noting also Editor Styles will need RTL version in css/editor-style-rtl.css, see also #23550.

#6 @lancewillett
12 years ago

.4 patch: update comment blocks (add a few periods, remove extra space before closing braces) and update CSS comment style to match main stylesheet.

@azaozz
12 years ago

#7 follow-up: @azaozz
12 years ago

Would there be a visible indication of the theme's width in the editor?


#8 in reply to: ↑ 7 @lancewillett
12 years ago

Replying to azaozz:

Would there be a visible indication of the theme's width in the editor?


We didn't do it in older default themes -- should we add it? I personally like it without.

#9 @azaozz
12 years ago

It's always been a bit weird that there is a well defined box where to type but the text wraps in the middle of it. On the other hand most users are used to that by now.

#10 @lancewillett
12 years ago

  • Cc kovshenin added

@kovshenin Do you have an opinion on the shaded background colors to show an idea of the content width?

#11 @kovshenin
12 years ago

I don't have a strong opinion on this. I can usually figure out the content width right after typing in the first line, and in DFW the dotted border is very helpful too. I also don't think it will hurt, even if people are used to it.

#12 @lancewillett
12 years ago

In 23672:

Twenty Thirteen: first pass at editor styles. Props Frank Klein and obenland. See #23551.

#13 @saltcod
12 years ago

@azaozz: On the other hand most users are used to that by now

That wrap still feels a little weird. I think I like the very light grey background.

Though if it's loaded by the theme, it will feel strange to them if/when they switch themes and it goes away.

#14 @lancewillett
12 years ago

As discussed in today's Twenty Thirteen office hours log -- another suggestion is to use a dotted gray line on the right side, similar style to the DFW interface.

Sounds like most people voted to leave it out entirely, though.

#15 @saracannon
12 years ago

  • Cc sararcannon@… added

I'd say leave it out. I can see showing the "max-width line" if the post editor will also adapt to smaller widths - in keeping with the responsive design. .. but we're not there yet ;)

#16 @lancewillett
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Let's open new tickets with new issues, this first pass is good for code freeze.

Note: See TracTickets for help on using tickets.