Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23568 closed defect (bug) (fixed)

Twenty Thirteen: Typo in browser prefix

Reported by: Jayjdk Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:


There's a small typo in the -moz prefix for in .site-header .searchform .field

Patch attached.

However, is some of the prefixes still necessary? Firefox has supported stuff like transition without a prefix since version 16. How long back is the theme supporting the different browsers? Because there's a whole lot more prefixes that could be removed - not just for Firefox.

Attachments (1)

23568.patch (570 bytes) - added by Jayjdk 3 years ago.

Download all attachments as: .zip

Change History (9)

3 years ago

#1 @lancewillett
3 years ago

  • Milestone changed from Awaiting Review to 3.6

Let's discuss the vendor prefix support in Twenty Thirteen office hours -- see http://make.wordpress.org/core for the times. Tomorrow is the next at 17 UTC.

I think we should support a few versions back but am open to suggestions and best practices. We should match our support for older browsers, and also agree that as long as the fallback isn't "broken" and looks good we can get rid of prefixes for properties that the most recent stable version of each browser implements fully.

#2 @lancewillett
3 years ago

Oh, and thank you for the ticket and patch. :)

#3 @lancewillett
3 years ago

  • Keywords commit added

#4 @lancewillett
3 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23464:

Twenty Thirteen: fix typo in browser transition prefix. Fixes #23568, props Jayjdk.

#5 @lancewillett
3 years ago

Based on notes in today's Twenty Thirteen office hours, we're going to take the following approach:

  • Look at each browser's prefix support. If it's been dropped in the stable version in the last year, we can remove it.
  • Keep in mind a webkit prefix may be needed for older mobile devices (http://isandroidgoodyet.com/).
  • We should mention here in the ticket notes that the theme itself may need to fail gracefully.

#6 @Jayjdk
3 years ago

Should it be in this ticket or a new one?

#7 @lancewillett
3 years ago

Go ahead and make a new one -- just change the title a bit, maybe "audit and clean up browser prefixes" or something.

#8 @Jayjdk
3 years ago

New ticket: #23582

Note: See TracTickets for help on using tickets.