WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#23569 closed defect (bug) (fixed)

Network Admin Email description falsely claims e-mails will be sent from it

Reported by: iandunn Owned by: westi
Milestone: 3.8 Priority: high
Severity: minor Version:
Component: Text Changes Keywords: has-patch
Focuses: Cc:

Description

The description for the Network Admin Email option on wp-admin/network/settings.php says, "Registration and support emails will come from this address. An address such as support@… is recommended."; but that's not true.

If the From name/address isn't set in wp_mail()'s $header argument, it gets set to "WordPress <wordpress@$sitename>".

What would a better description be? Maybe some like:

"Where you would like to be notified about new site creation and new user registration."

That would be consistent with the structure of the Network Name description just above it, which reads, "What you would like to call this network."

If that sounds good to others I'll go ahead and create a patch for it.

Attachments (6)

23569.diff (769 bytes) - added by iandunn 8 years ago.
23569.2.diff (736 bytes) - added by kovshenin 8 years ago.
23569.3.diff (704 bytes) - added by Hanni 8 years ago.
23569.4.diff (694 bytes) - added by Hanni 8 years ago.
23569.5.diff (664 bytes) - added by Hanni 8 years ago.
23569.6.diff (667 bytes) - added by Hanni 8 years ago.

Download all attachments as: .zip

Change History (25)

#1 @SergeyBiryukov
9 years ago

  • Component changed from Network Admin to Text Changes

@iandunn
8 years ago

#2 @iandunn
8 years ago

Uploaded a patch for this.

#3 @SergeyBiryukov
8 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.7

@kovshenin
8 years ago

#4 @kovshenin
8 years ago

Since you got rid of the placeholder, you don't really need printf anymore. See 23569.2.diff.

#5 @iandunn
8 years ago

Good catch.

#6 @johnbillion
8 years ago

  • Milestone changed from 3.7 to 3.8

We're also going to be sending automatic update (success/failure/nag) emails to the network admin email address, so this text might need changing still. Related: #10787.

@Hanni
8 years ago

#7 @Hanni
8 years ago

Updated the text to reflect the new use of the network admin email (sending update notifications) in 3.7.

#8 @westi
8 years ago

  • Owner set to westi
  • Resolution set to fixed
  • Status changed from new to closed

In 26359:

Improve the description of the Network Admin Email option to better describe what the address will be used for. Fixes #23569 props hanni, iandunn, kovshenin.

#9 @kpdesign
8 years ago

There's a typo in the patch that was just committed (first instance of 'notifications'):

"...will send update notifcations" should be "...will send update notifications".

@Hanni
8 years ago

#10 @Hanni
8 years ago

Fewer notifcations, more notifications.

#11 @westi
8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@Hanni
8 years ago

#12 @Hanni
8 years ago

I'm still learning to read, will get there one day. Updated.

@Hanni
8 years ago

#13 @Hanni
8 years ago

23569.6.diff should finally be at least vaguely correct.

#14 @ocean90
8 years ago

wpmu_signup_user_notification(), wpmu_signup_blog_notification() and wpmu_welcome_notification() are using the email address as the From address. So shouldn't it be:

This email address will receive update notifications, and also sent site creation and new user registration notifications.

#15 @iandunn
8 years ago

Good catch. I looked again and there's also wpmu_welcome_user_notification() and wp-admin/network/site-new.php. What's the reasoning behind those using a different From header than all the other e-mails Core sends out? I couldn't glean anything from the source or commit messages.

I'm guessing it's because with Multisite it's more important to distinguish between individual blogs in a network, but that's still relevant to multiple single-site installations, too, though. e.g., your inbox can have five different e-mails from five different websites, but they'll all show up as from "WordPress" because most mail clients only display the From name, not the From address.

Also, forging the header with the admin's e-mail is probably a bad idea because it'll make the e-mail look like spam, unless we also set the Sender header -- but even that will still cause problems with some hosts (#5007, #2532, #1532, #14888, etc).

Would it be better to do something like this instead?

  • Remove the custom From header from these functions
  • Set the default From name in wp_mail() as get_option( 'blogname' ), rather than "WordPress"
  • Always leave the default From address as wordpress@$sitename.

#16 follow-up: @nacin
8 years ago

  • Priority changed from normal to high

What's the impetus for the change here? What about something simple like "This email address will receive notifications. Registration and support emails will also come from this address."? Drop the "support@%s" recommendation and KISS.

This ticket was opened for the text change, and now has a commit against it, so let's not get sidetracked with screwing with From addresses.

#17 in reply to: ↑ 16 @westi
8 years ago

Replying to nacin:

What's the impetus for the change here? What about something simple like "This email address will receive notifications. Registration and support emails will also come from this address."? Drop the "support@%s" recommendation and KISS.

This ticket was opened for the text change, and now has a commit against it, so let's not get sidetracked with screwing with From addresses.

Agreed.

I'll close this out in a bit.

#18 @westi
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26640:

Improve the description of the Network Admin Email option to better describe what the address will be used for. Fixes #23569 props nacin.

#19 @nacin
8 years ago

In 26641:

westi forgot my full stop. see #23569.

Note: See TracTickets for help on using tickets.