WordPress.org

Make WordPress Core

#23571 closed defect (bug) (fixed)

Twenty Thirteen: improve styling for RSS widget title

Reported by: aaroncampbell Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The RSS widget links it's title, so it doesn't look like it fits with the other widgets.

Attachments (3)

47.png (46.3 KB) - added by aaroncampbell 17 months ago.
23571.diff (391 bytes) - added by sabreuse 17 months ago.
23571.2.diff (403 bytes) - added by Mamaduka 17 months ago.

Download all attachments as: .zip

Change History (12)

aaroncampbell17 months ago

comment:2 lancewillett17 months ago

  • Keywords needs-patch added
  • Summary changed from Twenty Thirteen: RSS Widget Title to Twenty Thirteen: improve styling for RSS widget title

sabreuse17 months ago

comment:3 sabreuse17 months ago

  • Keywords has-patch added; needs-patch removed

23571.diff styles linked widget titles to match the other widget titles. Links are still underlined on hover, so they're still discoverable as links.

comment:4 lancewillett17 months ago

@sabreuse Tiny thing with your patch -- can you put new selectors on a new line? We're following the WP CSS guidelines, see "Structure" here: http://make.wordpress.org/core/handbook/coding-standards/css/#structure.

Otherwise, the technique should work well and I can push the fix in.

Mamaduka17 months ago

comment:5 Mamaduka17 months ago

23571.2.diff Updates the patch to follow WP CSS guidelines, also uses better CSS selectors for widget titles as suggested in #23580.

comment:6 follow-up: obenland17 months ago

Do we really want to have them in the same color? It's a link after all, the others aren't.

comment:7 in reply to: ↑ 6 aaroncampbell17 months ago

Replying to obenland:

Do we really want to have them in the same color? It's a link after all, the others aren't.

I prefer it to be the same color. I think it looks best. However, I'm open to another option but I think the RSS Widget header should be further differentiated from the links in the widget content.

Any suggestions?

comment:8 lancewillett17 months ago

I think it's fine if it's the same color. On hover it changes to denote a link.

comment:9 lancewillett17 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23491:

Twenty Thirteen: improve styling for RSS widget title, fixes #23571.

Note: See TracTickets for help on using tickets.