Opened 12 years ago
Closed 12 years ago
#23571 closed defect (bug) (fixed)
Twenty Thirteen: improve styling for RSS widget title
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
The RSS widget links it's title, so it doesn't look like it fits with the other widgets.
Attachments (3)
Change History (12)
#2
@
12 years ago
- Keywords needs-patch added
- Summary changed from Twenty Thirteen: RSS Widget Title to Twenty Thirteen: improve styling for RSS widget title
#3
@
12 years ago
- Keywords has-patch added; needs-patch removed
23571.diff styles linked widget titles to match the other widget titles. Links are still underlined on hover, so they're still discoverable as links.
#4
@
12 years ago
@sabreuse Tiny thing with your patch -- can you put new selectors on a new line? We're following the WP CSS guidelines, see "Structure" here: http://make.wordpress.org/core/handbook/coding-standards/css/#structure.
Otherwise, the technique should work well and I can push the fix in.
#5
@
12 years ago
23571.2.diff Updates the patch to follow WP CSS guidelines, also uses better CSS selectors for widget titles as suggested in #23580.
#6
follow-up:
↓ 7
@
12 years ago
Do we really want to have them in the same color? It's a link after all, the others aren't.
#7
in reply to:
↑ 6
@
12 years ago
Replying to obenland:
Do we really want to have them in the same color? It's a link after all, the others aren't.
I prefer it to be the same color. I think it looks best. However, I'm open to another option but I think the RSS Widget header should be further differentiated from the links in the widget content.
Any suggestions?