WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 2 years ago

#23573 closed enhancement (fixed)

Twenty Thirteen as default theme

Reported by: JustinSainton Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Now that we're shipping with twentythirteen in trunk, it seems like it should probably be given the same loving preference and protection as the other defaults.

Patch attached.

Attachments (3)

23573.diff (747 bytes) - added by JustinSainton 8 years ago.
23573.1.diff (3.0 KB) - added by JustinSainton 8 years ago.
23573.2.diff (4.4 KB) - added by JustinSainton 8 years ago.

Download all attachments as: .zip

Change History (13)

@JustinSainton
8 years ago

#1 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 3.6

sidebars_widgets option in wp-admin/includes/upgrade.php and $_new_bundled_files array in wp-admin/includes/update-core.php need to be updated as well, see [22054].

http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/upgrade.php#L214
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/update-core.php#L541

#2 @SergeyBiryukov
8 years ago

  • Summary changed from Add Twenty Thirteen to private $default_themes array in WP_Theme to Twenty Thirteen as default theme

#3 @SergeyBiryukov
8 years ago

  • Type changed from defect (bug) to enhancement

#4 @JustinSainton
8 years ago

Probably default constant as well?

#5 @nacin
8 years ago

Full list of things that need to change:

  • WP_DEFAULT_THEME
  • WP_Theme
  • nav-menus.php help text
  • admin/includes/update-core.php $_new_bundled_files
  • sidebar_widgets and related options

#6 @JustinSainton
8 years ago

23573.1.diff addresses the following -

  • WP_DEFAULT_THEME constant
  • $_new_bundled_files in admin/includes/update-core.php
  • $default_themes in WP_Theme (Assuming that's the only area in WP_Theme you were referring to?)
  • sidebar_widgets option in admin/includes/upgrade.php. I'm not familiar enough with the neighboring options and how they've been considered in Twenty Thirteen to make educated changes there. Not yet, at least. Like the Twenty Eleven > Twenty Twelve changes, maybe nothing else changes?
  • Still need to change the nav-menus.php text. Patch forthcoming.

#7 @JustinSainton
8 years ago

23573.2.diff includes changes to the nav-menus.php file, changing Twenty Twelve and Twenty Eleven to Twenty Thirteen and Twenty Twelve.

#8 @lancewillett
8 years ago

  • Cc lancewillett added

#9 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 23529:

Make Twenty Thirteen the default theme.

Has the added benefit of ensuring the WordPress Beta Tester plugin allows updates of Twenty Thirteen.

props JustinSainton.
fixes #23573.

This ticket was mentioned in Slack in #core-committers by sergey. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.