WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#23586 closed defect (bug) (fixed)

Twenty Twelve: Content margin missing in some cases

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description (last modified by obenland)

When the background color is set to #fff or is not set at all, and a background image is added, the #page is missing margins to the left and right.

Attachments (2)

23586.diff (2.9 KB) - added by obenland 5 years ago.
23586.2.diff (2.4 KB) - added by lancewillett 5 years ago.

Download all attachments as: .zip

Change History (7)

@obenland
5 years ago

@lancewillett
5 years ago

#1 @lancewillett
5 years ago

Fix one indentation in functions.php logic. Also, I don't think you need the extra JS for background image handling.

#2 @lancewillett
5 years ago

OK, take back the part about the extra JS. It is needed, but still testing it out. I think there's one case it fails still.

#3 @lancewillett
5 years ago

  • Keywords commit added

First patch -- 23586.diff -- tests out well now, I had a cached JS file mistakenly.

#4 @obenland
5 years ago

  • Description modified (diff)

#5 @lancewillett
5 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23568:

Twenty Twelve: better handling for cases where a background color is set to white or an empty value (like first run with no theme_mods set) and a background image is enabled, which resulted previously in a broken layout. Fixes #23586, props obenland.

Note: See TracTickets for help on using tickets.