WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23589


Ignore:
Timestamp:
02/23/2013 12:19:11 AM (5 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23589 – Description

    initial v1  
    1 Steps to reproduce: 1) set up ssh access for wordpress (FTP_* constants), 3) define('FS_CHMOD_FILE', 0664), 2) install some theme. Expected result: files have 0664 permissions. Actual result: files have default permissions (0644).
     1Steps to reproduce:
     21. set up ssh access for !WordPress (FTP_* constants).
     32. `define('FS_CHMOD_FILE', 0664)`.
     43. install some theme.
    25
    3 I believe this happens because filename is ltrimmed before sending over SSH, but not restored before changing permissions. See [https://github.com/WordPress/WordPress/blob/master/wp-admin/includes/class-wp-filesystem-ssh2.php#L164 this].
     6Expected result: files have 0664 permissions.
     7
     8Actual result: files have default permissions (0644).
     9
     10I believe this happens because filename is ltrimmed before sending over SSH, but not restored before changing permissions. See [http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/class-wp-filesystem-ssh2.php#L164 this].