WordPress.org

Make WordPress Core

#23595 closed enhancement (wontfix)

Nav Menu: Auto-set the location if there's only one menu and one location

Reported by: bobbravo2 Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords:
Focuses: Cc:

Description (last modified by DrewAPicture)

Just finished testing 3.6-alpha-23451. Menus tested great in IE8+

IE7 Shows some CSS bugs: http://cl.ly/image/142s2y2Y452w Functionally speaking, IE7 works.
If we need to support IE7, let me know and I'll take a stab at the browser quirks.

One UX note is that the checkbox
http://f.cl.ly/items/3K373n2t0P2k3p2h1b3d/Screen%20Shot%202013-02-23%20at%2010.03.13%20AM.png
feels unnecessary if (menus == 1 && theme_locations == 1)

The UX seems broken when I "Create Menu" on my fresh new WordPress site, and then go to the homepage and see the fallback pages menu. The 1 menu should automatically be used, and the checkboxes only shown when $menus > 1.

And because I'm a huge web geek, the menus in IE6: http://cl.ly/image/1P140s1K2r0f Thank the gods we don't have to support that anymore!

I tried applying the 23119.31.refresh.patch patch as well, but there were some missing files, let me know which one you'd like more testing on, or if I should just test trunk.

Change History (9)

comment:1 DrewAPicture14 months ago

  • Cc xoodrew@… added
  • Component changed from General to Menus
  • Description modified (diff)
  • Keywords 3.6-menus added
  • Version set to trunk

comment:2 in reply to: ↑ description ; follow-up: DrewAPicture14 months ago

Replying to bobbravo2:

IE7 Shows some CSS bugs: http://cl.ly/image/142s2y2Y452w Functionally speaking, IE7 works.
If we need to support IE7, let me know and I'll take a stab at the browser quirks.

The rule of thumb with IE7, is not horribly broken.

One UX note is that the checkbox
http://f.cl.ly/items/3K373n2t0P2k3p2h1b3d/Screen%20Shot%202013-02-23%20at%2010.03.13%20AM.png
feels unnecessary if (menus == 1 && theme_locations == 1)

The UX seems broken when I "Create Menu" on my fresh new WordPress site, and then go to the homepage and see the fallback pages menu. The 1 menu should automatically be used, and the checkboxes only shown when $menus > 1.

I disagree with hiding the locations at all, especially since we don't have the dedicated locations meta box anymore. Users need to be able to un-assign the one menu from the one location.

I tried applying the 23119.31.refresh.patch patch as well, but there were some missing files, let me know which one you'd like more testing on, or if I should just test trunk.

All accepted changes were committed from #23119 so we're testing on trunk.

See also: #23449, #23450

comment:3 SergeyBiryukov14 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:4 in reply to: ↑ 2 ; follow-up: bobbravo214 months ago

Replying to DrewAPicture:

Replying to bobbravo2:

IE7 Shows some CSS bugs: http://cl.ly/image/142s2y2Y452w Functionally speaking, IE7 works.
If we need to support IE7, let me know and I'll take a stab at the browser quirks.

The rule of thumb with IE7, is not horribly broken.

Gotchya - I'll do some more testing - but it appears to be 100% functional.

I disagree with hiding the locations at all, especially since we don't have the dedicated locations meta box anymore. Users need to be able to un-assign the one menu from the one location.

What use case is this? Would this be a custom menu being used in a widget?
In any case - I think once you save your first menu, it should default to being enabled. Otherwise it's adding another step in an otherwise intuitive process.

I tried applying the 23119.31.refresh.patch patch as well, but there were some missing files, let me know which one you'd like more testing on, or if I should just test trunk.

All accepted changes were committed from #23119 so we're testing on trunk.

Great.

See also: #23449, #23450

comment:5 in reply to: ↑ 4 ; follow-up: DrewAPicture14 months ago

Replying to bobbravo2:

I disagree with hiding the locations at all, especially since we don't have the dedicated locations meta box anymore. Users need to be able to un-assign the one menu from the one location.

What use case is this? Would this be a custom menu being used in a widget?
In any case - I think once you save your first menu, it should default to being enabled. Otherwise it's adding another step in an otherwise intuitive process.

I have no problem auto-setting the location if there's only one menu and one location, that seems like logical UX.

But we shouldn't hide the checkbox just because there's only one menu. This would mean the only way to unset the location would be to add a second menu which seems even more unintuitive to me.

comment:6 ocean9014 months ago

  • Keywords ux-feedback added; needs-testing removed
  • Summary changed from Nav Menus Testing to Nav Menu: Auto-set the location if there's only one menu and one location

@bobbravo2
Please don't summarize multiple issues in one ticket. Lets separate them in different tickets. IE7 should be another ticket (but not really needed yet :)

comment:7 in reply to: ↑ 5 bobbravo214 months ago

Replying to DrewAPicture:

Replying to bobbravo2:

I disagree with hiding the locations at all, especially since we don't have the dedicated locations meta box anymore. Users need to be able to un-assign the one menu from the one location.

What use case is this? Would this be a custom menu being used in a widget?
In any case - I think once you save your first menu, it should default to being enabled. Otherwise it's adding another step in an otherwise intuitive process.

I have no problem auto-setting the location if there's only one menu and one location, that seems like logical UX.

Awesome.

But we shouldn't hide the checkbox just because there's only one menu. This would mean the only way to unset the location would be to add a second menu which seems even more unintuitive to me.

Good point. I agree w/ you.

@ocean90
That's what I thought - do we need to support IE7? The only reason I mentioned it is to confirm that functionally it works - but isn't pretty.

comment:8 DrewAPicture14 months ago

  • Type changed from defect (bug) to enhancement

comment:9 lessbloat14 months ago

  • Keywords 3.6-menus ux-feedback removed
  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

In office hours on Monday, we decided to forgo auto-selecting the single theme location when adding a new menu from the "add new" screen.

A couple of notes:

  • It is auto-selected if you go through the blank slate screen (when you have zero menus, and only one theme location)
  • We decided to do it on the "add new" screen because users may be attempting to add a custom menu widget. Auto-selecting the theme location would only confuse them.
Note: See TracTickets for help on using tickets.