Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#23607 closed task (blessed) (fixed)

3.6-Nav Menus Tracking Ticket

Reported by: drewapicture's profile DrewAPicture Owned by: lessbloat's profile lessbloat
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: 3.6-menus
Focuses: Cc:

Description (last modified by DrewAPicture)

This ticket is for tracking any tickets related to the 3.6 Nav Menus Refresh action item.

The mammoth ticket that was formerly our home (#23119) has been closed as fixed and any further related tickets should be added here.

  • #23119 - The original 3.6-menus ticket. Substantial changes to the UI were commited via [23441] and [23453].

Other 3.6-menus tickets:

  • #23449 - Refactor the Customizer accordion to be reusable elsewhere in core.
  • #23450 - Refactor menu item meta boxes into an accordion via #23449
  • #14045 - Give the menus page an accessibility mode (like widgets)
  • #23608 - 3.6-Menus Help Text changes
  • #23610 - Relocate the 'Delete Menu' link on the Menus screen
  • #23641 - Tweaks to menu management box
  • #23645 - RTL fixes for Nav Menu UI refresh
  • #23714 - Remove menus message slide down effect
  • #23716 - Discuss theme locations as meta box vs checkboxes
  • #23770 - Restore 'Locations' meta box functionality as secondary tab in Menus UI
  • #23813 - Menu select should use get instead of post

Other tickets for consideration:

  • #23508 - get_nav_menu_locations() should always return an array

If there are others that were missed, post a comment and we'll add them to the list.

Attachments (4)

23607.diff (792 bytes) - added by lessbloat 11 years ago.
nav-menus-saved.2.png (74.4 KB) - added by helen 11 years ago.
nav-menus-saved-diff.png (75.5 KB) - added by helen 11 years ago.
Select-menu-to-edit.png (46.5 KB) - added by jb510 11 years ago.
Move select menu to edit into menu edit box

Download all attachments as: .zip

Change History (30)

#1 @DrewAPicture
11 years ago

  • Owner set to lessbloat
  • Status changed from new to assigned

#2 @DrewAPicture
11 years ago

  • Description modified (diff)

#3 @DrewAPicture
11 years ago

  • Description modified (diff)

#4 @DrewAPicture
11 years ago

Added:

  • #23608 for 3.6-Menus Help Text changes
  • #23610 for relocating the 'Delete Menu' link on the Menus screen

#5 @bobbravo2
11 years ago

Here it is in IE7: http://cl.ly/image/0a0v1D0h2E0P All JS Functions properly (tested w/ script debug against 3.6-alpha-23451)

#6 @lessbloat
11 years ago

  • Description modified (diff)

#7 @jkudish
11 years ago

  • Cc jkudish added

#8 @Viper007Bond
11 years ago

More UI hooks please! #18584

Version 0, edited 11 years ago by Viper007Bond (next)

#9 @DrewAPicture
11 years ago

  • Description modified (diff)

#10 @DrewAPicture
11 years ago

Added #23645 for RTL fixes

#11 @DrewAPicture
11 years ago

  • Description modified (diff)

#12 @DrewAPicture
11 years ago

  • Description modified (diff)

Added #18584 - Nav Menu UI needs more hooks

#13 @alex-ye
11 years ago

  • Cc nashwan.doaqan@… added

#14 @DrewAPicture
11 years ago

  • Description modified (diff)

Removed (Future Release):

  • #16075 - Add post type archives support to menus

#15 @DrewAPicture
11 years ago

  • Description modified (diff)

Removed:

  • #18584 - Nav Menu UI needs more hooks (it's still very much up in the air due to #14134)

#16 follow-up: @anointed
11 years ago

  • Cc imtiedup@… added

Run into a situation where we are using multiple themes on a single website. Basically each page can be assigned a custom theme.

The issue I have run into is the only way to assign a menu to a new page with a 'custom theme' for that page, is to temporarily activate the new theme on the website, assign the menu to its location, and then reactivate the original theme.

While this works, it obviously disrupts the entire system as I have to change the active theme for the site to make this change.

I spent a bit of time looking, but I do not see anywhere that I can hook into to define the theme that I am working with on the menu admin page.

As this is an unusual situation, I don't expect a lot of traction, but one thing that does come up A LOT is people hating that they loose their menu locations when changing themes. It might be nice to have the option of selecting a theme to apply the menus to in this new revamp or at least a hook, else I am afraid it could be a very long time before this would ever be addressed again.

#17 in reply to: ↑ 16 @DrewAPicture
11 years ago

Replying to anointed:

As this is an unusual situation, I don't expect a lot of traction ...<snip>

You're correct, that's pretty edge. I suggest you take a look at #18584 as it's more in-line with proposing additional hooks on the menu screen(s).

#18 @DrewAPicture
11 years ago

  • Description modified (diff)

Added:

  • #23714 - Remove menus message slide down effect
  • #23716 - Discuss theme locations as meta box vs checkboxes

#19 @DrewAPicture
11 years ago

  • Description modified (diff)

Added:

  • #23770 - Restore 'Locations' meta box functionality as secondary tab in Menus UI

#20 follow-ups: @helen
11 years ago

Thinking the select a menu form should be get instead of post. Also that the form actions should probably not just be the bare admin URL (that is, without any query variables). Can make a new ticket if that seems right.

@lessbloat
11 years ago

#21 in reply to: ↑ 20 ; follow-up: @lessbloat
11 years ago

Replying to helen:

Thinking the select a menu form should be get instead of post.

Done in 23607.diff​.

Also that the form actions should probably not just be the bare admin URL (that is, without any query variables). Can make a new ticket if that seems right.

Sorry, not sure I follow. The query vars are auto added to the base URL on submission of the form.

#22 in reply to: ↑ 20 @DrewAPicture
11 years ago

  • Description modified (diff)

Replying to helen:

Thinking the select a menu form should be get instead of post.

Created a ticket for that: #23813

#23 in reply to: ↑ 21 @helen
11 years ago

Replying to lessbloat:

The query vars are auto added to the base URL on submission of the form.

Not if we switch to get instead of post for the switcher :) It's the difference between these (see URLs):

http://core.trac.wordpress.org/raw-attachment/ticket/23607/nav-menus-saved.2.png

http://core.trac.wordpress.org/raw-attachment/ticket/23607/nav-menus-saved-diff.png

#24 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Version set to trunk

As of [23844], the last ticket on our list is closed.

Any other menus issues that come up in beta should be opened as separate tickets.

@jb510
11 years ago

Move select menu to edit into menu edit box

#25 @jb510
11 years ago

I'm still really uncomfortable with the new menu layout. I'm usually pretty pro-UX change, but I've been using this for a couple weeks and this still just feels wrong. Things are redundant... things are not logically organized.

I've manage to begrudingly get used to setting menu locations in two places. It's confusing, but I'm not sure what else you could do.

Selecting which menu to edit still seem laid out wrong. Why would it be visually separated from the dialog being used to actually edit the menu. It seems to me the layout should be like the attached.

http://core.trac.wordpress.org/raw-attachment/ticket/23607/Select-menu-to-edit.png

#26 @ericlewis
10 years ago

Can someone point me to (or summarize) the decision on the "Common Links" box that would've included things like "Log in," Log Out," etc?

Note: See TracTickets for help on using tickets.