WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#23621 closed defect (bug) (wontfix)

Twenty Thirteen: use core functionality to find first image in gallery post format

Reported by: lancewillett Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Use a core function to find and display the first image in the post, "first image attached to post" or better yet, first image from the gallery based on the gallery shortcode settings (because user can change ordering).

See #22960 for proposed new core functions.

Twenty Thirteen only needs to work in 3.6?+. See also #22907 for a similar issue in Twenty Eleven.

Attachments (1)

Screen Shot 2013-02-28 at 1.51.16 PM.png (307.8 KB) - added by taupecat 3 years ago.
A screenshot of a gallery post edit page in wp-admin.

Download all attachments as: .zip

Change History (10)

comment:1 @lancewillett3 years ago

  • Milestone set to 3.6

comment:2 @alexvorn23 years ago

  • Summary changed from Twenty Thirteen: use core functionality to find first image in gallery in gallery post format to Twenty Thirteen: use core functionality to find first image in gallery post format

comment:3 @sabreuse3 years ago

  • Cc sabreuse added

comment:4 @taupecat3 years ago

  • Cc tracy@… added

I've been looking into this. This is what's causing *nothing* (as in no content; title displays fine) to appear when the gallery is part of an archive/index page, correct? See: http://family.rotton.com/ (where the first post as of the writing of this comment is a gallery), correct?

Last edited 3 years ago by taupecat (previous) (diff)

comment:5 @lancewillett3 years ago

Tracy, it could be. Could you post a screenshot here of the gallery post's editor page from wp-admin? So we can repeat the way you created the gallery content.

@taupecat3 years ago

A screenshot of a gallery post edit page in wp-admin.

comment:6 @WraithKenny2 years ago

functions in #22960 were committed.

comment:7 @lancewillett2 years ago

In 23786:

Twenty Thirteen: we loves us some structured post formats. See #23619 #23620 #23621.

comment:8 @lancewillett2 years ago

  • Keywords close added; needs-patch removed

Turns out with Twenty Thirteen we aren't going to parse out the first image from the gallery, after all.

That *will* be useful for Twenty Eleven, though.

Twenty Thirteen displays the entire gallery on both index and single views. Here's what it does to make it fancier on the index view:

  1. uses CSS to make the first image 300px by 300px
  2. uses CSS to crop the other thumbnails to square size
  3. uses a shortcode attributes filter to make the images larger -- which avoids upscaling a 150px by 150px thumbnail to 300px.

I think that means we can close this as "wontfix" -- @obenland, your thoughts?

comment:9 @obenland2 years ago

  • Keywords close removed
  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Agreed.

Note: See TracTickets for help on using tickets.