Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23631 closed defect (bug) (fixed)

Twenty Thirteen: Multisite register screen content is too wide

Reported by: kwight Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


The Register screen for Multisite (wp-signup.php) is too wide; it has no defining widths for content.

Attachments (5)

multisite-register.png (144.2 KB) - added by kwight 3 years ago.
23631.diff (350 bytes) - added by DrewAPicture 3 years ago.
mu_signup_max_width.png (84.7 KB) - added by DrewAPicture 3 years ago.
With max-width 1040px
23631.2.diff (3.2 KB) - added by kwight 3 years ago.
23631.3.diff (1.1 KB) - added by kwight 3 years ago.

Download all attachments as: .zip

Change History (12)

#1 @lancewillett
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.6

3 years ago

3 years ago

With max-width 1040px

#2 @DrewAPicture
3 years ago

  • Keywords has-patch added; needs-patch removed

23631.diff adds a max-width of 1040px for .mu_register. Feel free to move it wherever seems appropriate.

Viewable in mu_signup_max_width.png

3 years ago

#3 @kwight
3 years ago

I went a little heavier here with 23631.2.diff.

  • Changed some markup in wp-signup.php, allowing better targeting of helper text (I don't believe it could affect anything in the wild)
  • Removed some aggressive form field styling in wp-signup.php, which allows more consistent styling by inheritance (helps Twenty Twelve a bit too)
  • Went with a narrower 604px single-column width for the form's container
  • Some additional Twenty Thirteen specific styling

If there's interest in this direction, I'm assuming the signup.php changes should be done in a new separate ticket?..

Last edited 3 years ago by kwight (previous) (diff)

#4 @lancewillett
3 years ago

Yes, please only patch Twenty Thirteen here. (The signup.php stuff in a different ticket.)

3 years ago

#5 @kwight
3 years ago

23631.3.diff styles Multisite forms without relying on wp-signup.php markup changes.

#6 @lancewillett
3 years ago

Good patch, Kirk -- only change I made was swap lines 2446 and 2447, for alphabetical properties within the block.

#7 @lancewillett
3 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23513:

Twenty Thirteen: style the multisite registration form, props kwight. Fixes #23631.

Note: See TracTickets for help on using tickets.