WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 8 months ago

#23637 new defect (bug)

wp-signup.php has overly aggressive CSS

Reported by: kwight Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Login and Registration Keywords: ui-feedback needs-patch
Focuses: ui, multisite Cc:

Description

The CSS added through wp_head by wp-signup.php stops Multisite form fields from being styled through inheritance. Allowing inheritance will result in more consistent styling with the active theme (for example, field font-size).

Attachments (1)

23637.diff (1.5 KB) - added by kwight 4 years ago.

Download all attachments as: .zip

Change History (10)

@kwight
4 years ago

#1 @kwight
4 years ago

  • Keywords has-patch added

23637.diff removes forced filed styling, tidies up inconsistent spacing, and adds some margin above .mu_alert.

#4 @SergeyBiryukov
4 years ago

  • Version changed from trunk to 3.0

#5 @jeremyfelt
3 years ago

  • Keywords ui-feedback added

#6 @jeremyfelt
3 years ago

  • Component changed from Multisite to Login and Registration
  • Focuses ui multisite added

#7 @chriscct7
14 months ago

  • Keywords needs-refresh added; has-patch removed

#8 follow-up: @jeremyfelt
14 months ago

  • Keywords needs-patch added; needs-refresh removed
  • Milestone changed from Awaiting Review to Future Release

I tested this from Twenty Ten to Twenty Fifteen and I don't think we can make the CSS change directly. We've been relying on the font size and padding specified on those styles throughout.

Adding a margin-top on the alert does not help any of the default themes, though adding margin-bottom: 2em; does a world of wonders. That may be a different ticket though, as I wonder if something like 22187/22187-signup-styles.diff does work better for this to make it easier to unhook the inline stylesheet.

#9 in reply to: ↑ 8 @jeremyfelt
8 months ago

Replying to jeremyfelt:

I wonder if something like 22187/22187-signup-styles.diff does work better for this to make it easier to unhook the inline stylesheet.

This won't work because wp-activate.php doesn't load plugins. Excellent. :)

Note: See TracTickets for help on using tickets.