#23641 closed enhancement (fixed)
Tweaks to menu management box
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Menus | Keywords: | 3.6-menus has-patch commit needs-codex |
Focuses: | Cc: |
Description (last modified by )
In office hours on Monday we discussed making some changes to the menu management box currently at the top of the menus screen (when you have more than one menu).
We are going to show the box at all times with the following:
Zero menus: Edit your menu below, or start with a blank menu
One menu: Edit your menu below, or add a new menu
Multiple menus: Select a menu to edit [DROPDOWN] [SELECT] or add a new menu
Attachments (8)
Change History (31)
#4
@
12 years ago
- Cc xoodrew@… added
- Keywords has-patch added; needs-patch removed
- Version set to trunk
#5
follow-up:
↓ 6
@
12 years ago
I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:
Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.
#6
in reply to:
↑ 5
;
follow-up:
↓ 7
@
12 years ago
Replying to lessbloat:
I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:
Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.
Looks pretty good. For zero menus, what about this:
Edit your menu below, or create a new blank menu
instead of this:
Edit your menu below, or create a blank new menu
#7
in reply to:
↑ 6
@
12 years ago
Replying to DrewAPicture:
For zero menus, what about this:
Edit your menu below, or create a new blank menuinstead of this:
Edit your menu below, or create a blank new menu
Let's just go with: Edit your menu below, or create a new menu.
What do you say?
#8
@
12 years ago
Talked with @lessbloat and we decided to go with one new string all around for the second part of the 'sentence', handled in 23641.4.diff
Zero & one menus:
Edit your menu below, or create a new menu.
Multiple menus:
Select a menu to edit [dropdown] [Select] or create a new menu.
#10
@
12 years ago
I don't think you can break up sentences or it messes with translation.
<?php _e( 'Edit your menu below, or' ); ?> <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ); ?>"><?php esc_html_e( 'create a new menu' ); ?></a>
Should be something like this:
<?php printf( __( 'Edit your menu below, or <a href="%s">create a new menu</a>' ), esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ) ); ?>
We may need to have one of the translators look at this or at least someone with more translation chops than me.
#11
@
12 years ago
23641.5.diff looks good to me in terms of the strings.
Minor corrections in 23641.6.diff:
- Added an ending dot to the string in line 465 for consistency with the one in line 499.
- Added a colon to the string in line 470.
#12
@
12 years ago
- Owner set to markjaquith
- Resolution set to fixed
- Status changed from new to closed
In 23622:
#14
follow-ups:
↓ 15
↓ 16
@
12 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).
#15
in reply to:
↑ 14
@
12 years ago
Replying to markjaquith:
Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).
Maybe @lessbloat could add this to the next round of user tests. Worth looking at.
I also reopened #23645 pending other RTL fixes.
#16
in reply to:
↑ 14
@
12 years ago
Replying to markjaquith:
Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).
I'm all for it. Done in 23641.7.diff.
23641.2.diff removes the 'Add New' button next to the screen icon and adds differing text based on
$menu_count
.Zero menus:
One menu:
Two+ menus: