WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#23641 closed enhancement (fixed)

Tweaks to menu management box

Reported by: lessbloat Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Menus Keywords: 3.6-menus has-patch commit needs-codex
Focuses: Cc:
PR Number:

Description (last modified by lessbloat)

In office hours on Monday we discussed making some changes to the menu management box currently at the top of the menus screen (when you have more than one menu).

We are going to show the box at all times with the following:

Zero menus: Edit your menu below, or start with a blank menu
One menu: Edit your menu below, or add a new menu
Multiple menus: Select a menu to edit [DROPDOWN] [SELECT] or add a new menu

Attachments (8)

23641.diff (2.0 KB) - added by DrewAPicture 7 years ago.
23641.2.diff (2.6 KB) - added by DrewAPicture 7 years ago.
23641.3.diff (2.8 KB) - added by lessbloat 7 years ago.
23641.4.diff (2.7 KB) - added by DrewAPicture 7 years ago.
Consolidate two new strings to one: 'create a new menu'
23641.5.diff (2.7 KB) - added by jkudish 7 years ago.
fixes the translation strings
23641.6.diff (2.7 KB) - added by SergeyBiryukov 7 years ago.
23641.7.diff (568 bytes) - added by lessbloat 7 years ago.
23641.8.diff (577 bytes) - added by DrewAPicture 7 years ago.
'Add New' w/ context

Download all attachments as: .zip

Change History (31)

#1 @lessbloat
7 years ago

  • Description modified (diff)

#2 @lessbloat
7 years ago

  • Keywords 3.6-menus added

#3 @jkudish
7 years ago

  • Cc jkudish added

@DrewAPicture
7 years ago

@DrewAPicture
7 years ago

#4 @DrewAPicture
7 years ago

  • Cc xoodrew@… added
  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

23641.2.diff removes the 'Add New' button next to the screen icon and adds differing text based on $menu_count.

Zero menus:

http://f.cl.ly/items/4604161W3s1M3f400M3q/Screen%20Shot%202013-02-28%20at%2010.55.41%20AM.png

One menu:

http://f.cl.ly/items/471Z1R273v21471P301G/Screen%20Shot%202013-02-28%20at%2010.57.49%20AM.png

Two+ menus:

http://f.cl.ly/items/471l1u0j3J0i1B1I3H0m/Screen%20Shot%202013-02-28%20at%2011.17.04%20AM.png

@lessbloat
7 years ago

#5 follow-up: @lessbloat
7 years ago

I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:

Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.

#6 in reply to: ↑ 5 ; follow-up: @DrewAPicture
7 years ago

Replying to lessbloat:

I tweaked a couple minor things in 23641.3.diff. Added a period at the end of each sentence, removed the ternary operator, and changed the sentences to read:

Zero: Edit your menu below, or create a blank new menu.
One: Edit your menu below, or add a new menu.
Multiple: Select a menu to edit [dropdown] [Select] or add a new menu.

Looks pretty good. For zero menus, what about this:

 Edit your menu below, or create a new blank menu

instead of this:

 Edit your menu below, or create a blank new menu

#7 in reply to: ↑ 6 @lessbloat
7 years ago

Replying to DrewAPicture:

For zero menus, what about this:

 Edit your menu below, or create a new blank menu

instead of this:

 Edit your menu below, or create a blank new menu

Let's just go with: Edit your menu below, or create a new menu.

What do you say?

@DrewAPicture
7 years ago

Consolidate two new strings to one: 'create a new menu'

#8 @DrewAPicture
7 years ago

Talked with @lessbloat and we decided to go with one new string all around for the second part of the 'sentence', handled in 23641.4.diff

Zero & one menus:

Edit your menu below, or create a new menu.

Multiple menus:

Select a menu to edit [dropdown] [Select] or create a new menu.

#9 @lessbloat
7 years ago

  • Keywords commit added

23641.4.diff​ looks solid to me.

#10 @aaroncampbell
7 years ago

I don't think you can break up sentences or it messes with translation.

<?php _e( 'Edit your menu below, or' ); ?> <a href="<?php echo esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ); ?>"><?php esc_html_e( 'create a new menu' ); ?></a>

Should be something like this:

<?php
printf( __( 'Edit your menu below, or <a href="%s">create a new menu</a>' ), esc_url( add_query_arg( array( 'action' => 'edit', 'menu' => 0 ), admin_url( 'nav-menus.php' ) ) ) );
?>

We may need to have one of the translators look at this or at least someone with more translation chops than me.

@jkudish
7 years ago

fixes the translation strings

#11 @SergeyBiryukov
7 years ago

23641.5.diff looks good to me in terms of the strings.

Minor corrections in 23641.6.diff:

  • Added an ending dot to the string in line 465 for consistency with the one in line 499.
  • Added a colon to the string in line 470.

#12 @markjaquith
7 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 23622:

Tweak the Nav Menu UX, especially around menu creation.

props lessbloat, DrewAPicture, jkudish. fixes #23641

#13 @markjaquith
7 years ago

In 23623:

RTL for Nav Menu tweaks. see #23641. fixes #23645. props DrewAPicture.

#14 follow-ups: @markjaquith
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

#15 in reply to: ↑ 14 @DrewAPicture
7 years ago

Replying to markjaquith:

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

Maybe @lessbloat could add this to the next round of user tests. Worth looking at.

I also reopened #23645 pending other RTL fixes.

@lessbloat
7 years ago

#16 in reply to: ↑ 14 @lessbloat
7 years ago

Replying to markjaquith:

Reopening to discuss keeping "Add New" next to the h2 for consistency. I get that it's doubled up, but it's sort of a standard (even if people were "missing" it on this screen).

I'm all for it. Done in 23641.7.diff.

#17 follow-up: @pavelevap
7 years ago

"Add New" string should have context?

@DrewAPicture
7 years ago

'Add New' w/ context

#18 in reply to: ↑ 17 @DrewAPicture
7 years ago

Replying to pavelevap:

"Add New" string should have context?

Good catch. Added in 23641.8.diff

#19 @markjaquith
7 years ago

In 23641:

Add back "Add New" next to h2 on Nav Menus screen.

props DrewAPicture. see #23641

#20 @DrewAPicture
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

An new issues with this should be in a new ticket.

Last edited 7 years ago by DrewAPicture (previous) (diff)

#21 @ryan
7 years ago

In 23748:

RTL for Nav Menu tweaks. see #23641. see #23645. props DrewAPicture

#22 @markjaquith
7 years ago

In 23808:

RTL for Nav Menu tweaks. see #23641. see #23645. props lessbloat

#23 @DrewAPicture
7 years ago

  • Keywords needs-codex added
Note: See TracTickets for help on using tickets.