WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23643 closed defect (bug) (fixed)

Redundant use of esc_url() in wp-admin/includes/export.php

Reported by: pauldewouters Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.0
Component: Export Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

In ticket #13555, esc_url() was moved into the_guid() function. See: [14949]

but it wasn't removed from this line
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/export.php#L374

I'd like to submit a fix to remove esc_url() as it is already called inside the_guid()

Attachments (1)

remove-redundant-escape-url.23643.diff (869 bytes) - added by pauldewouters 3 years ago.
remove redundant esc_url

Download all attachments as: .zip

Change History (4)

@pauldewouters3 years ago

remove redundant esc_url

comment:1 @pauldewouters3 years ago

  • Keywords has-patch added

comment:2 @SergeyBiryukov3 years ago

  • Description modified (diff)
  • Keywords commit added; dev-feedback removed
  • Milestone changed from Awaiting Review to 3.6
  • Version set to 3.0

comment:3 @SergeyBiryukov3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23553:

Remove redundant esc_url() call. props pauldewouters. fixes #23643.

Note: See TracTickets for help on using tickets.