Opened 12 years ago
Closed 12 years ago
#23649 closed defect (bug) (fixed)
Twenty Thirteen: Show portrait images correctly in gallery post formats
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description (last modified by )
The custom implementation of featured galleries in index view currently does not handle portrait formatted images very well:
Attachments (5)
Change History (13)
#3
in reply to:
↑ 2
@
12 years ago
Replying to lancewillett:
max-height: 1000%
looks unintentional :)
It just needs to be set to a value where the image covers the whole width of the thumbnail. Or removed, which I will do in the next patch.
- For
twentythirteen_get_attachment_link
no other way to get that information from core and avoid this extra code? It'd be cool if core output the orientation for *all* themes to take advantage of it.
I'm not sure. wp_get_attachment_link()
is a generic function that returns links to all attachment types, not only images. We could make that check in gallery_caption()
and add a class to the icon tag. But I'm not sure it'll find its way into core in time.
#4
@
12 years ago
I'd vote "wontfix" to this ticket unless we can get the new class value into core -- it really should not be part of the theme.
If the layout can't be fixed without the class, let's redo the layout to center all the images and go away from the need for a "perfect grid" here.
#5
@
12 years ago
Based on core office hours discussion today, obenland is going to work on a patch to add this to core gallery functionality, working with nacin to get it into 3.6 before freeze.
Can you upload before / after screenshots?
In patch:
max-height: 1000%
looks unintentional :)twentythirteen_get_attachment_link
no other way to get that information from core and avoid this extra code? It'd be cool if core output the orientation for *all* themes to take advantage of it.