WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 7 months ago

#23662 closed enhancement (wontfix)

Twenty Twelve: style.css with Table of Contents

Reported by: TomasM Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.5
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Hello, I really like the 2013 initiative with Table of Contents, because it helps new users understand where goes what, especially developing child themes.

I added Table of Contents to Twenty Twelve theme and renamed CSS comments titles accordingly.

Attachments (2)

style with Table of Contents.css (36.0 KB) - added by TomasM 14 months ago.
23662.patch (8.4 KB) - added by ocean90 14 months ago.

Download all attachments as: .zip

Change History (11)

ocean9014 months ago

comment:1 TomasM14 months ago

Thanks, ocean90! ;)

comment:2 DrewAPicture14 months ago

  • Cc xoodrew@… added
  • Keywords has-patch added

+1 for 23662.patch

comment:3 TomasM14 months ago

@DrewAPicture I noticed, that for some reason "7.0 - Aside post format" was separated from other post formats in the section 8.0. I didn't want to take a freedom and mess with the structure, but perhaps it would be good to move that peace of code down under "8.0 - Post formats"?

Last edited 14 months ago by TomasM (previous) (diff)

comment:4 SergeyBiryukov14 months ago

  • Version changed from trunk to 3.5

comment:5 lancewillett13 months ago

  • Keywords dev-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Let's skip this, and put our efforts to newer themes instead. Thirteen and onward.

I don't think it's worth the effort for the older themes.

comment:6 TomasM13 months ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I'm sorry but I disagree. There is nothing to fix, everything is done and patch is ready.

You can focus on new theme, but I'm focusing on a theme, that I really like, like many others. And this patch will improve understanding about this theme for new users.

Plus 2012 is much better starting point for normal website. 2013 is good only for a blog.

We spent our time for this and this adds value for the whole community.

comment:7 lancewillett13 months ago

  • Milestone set to Future Release

It's still a maintenance burden regardless of focus, and doesn't provide enough value to warrant the change right now. I'd be open to discussing this early in the 3.7 cycle, including refactoring all the stylesheets from default themes to add better organization and clean everything up to match WP CSS style guidelines.

comment:8 TomasM13 months ago

If you would add it now, it would be a precedent, something to work on later or extend. Otherwise it might be buried.

And "refactoring all the stylesheets" - that would be a real burden. This patch fixes 90% of problem without more work to do if it would be decided.

comment:9 lancewillett7 months ago

  • Keywords has-patch removed
  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.