WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23673, comment 8


Ignore:
Timestamp:
03/21/13 16:38:47 (13 months ago)
Author:
bpetty
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23673, comment 8

    initial v1  
    55It should be clear to anyone looking at this code (as distributed from WP) what it's license and conditions are, and it should probably include both licenses with the library here. 
    66 
    7 Also, I know this has been here for review for a while, but was there really not any way this could have been built in a more modular way so we're not including 20k lines of new PHP code just for this library (an additional 940KB for every WP install). For reference, that's about 6k more than every `WP_*` class currently included in WP, 4k more than SimplePie, and accounts for 15% of everything in `wp-includes`. 
     7Also, I know this has been here for review for a while, but was there really not any way this could have been built in a more modular way so we're not including 20k lines of new PHP code just for this library (an additional 940KB for every WP install)? For reference, that's about 6k more than every `WP_*` class currently included in WP, 4k more than SimplePie, and accounts for 15% of everything in `wp-includes`. 
    88 
    99This might only be used for maybe 10% to 15% of all installations, and even then, most users are only going to make use of the MP3 handler. They've have had plenty of ways of embedding audio and video into their site without needing any of this for a long time. I'm not saying it isn't useful, just that it's a lot to include in WP by default for something so far from the 80/20 rule.