WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#23680 closed enhancement (fixed)

Obsolete function previously used in Theme Editor

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 3.7 Priority: normal
Severity: normal Version: 2.9
Component: Administration Keywords:
Focuses: Cc:

Description

get_real_file_to_edit() is unused since [12063] and should probably be deprecated:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/file.php#L96

Attachments (2)

23680.diff (731 bytes) - added by iamfriendly 4 years ago.
23680-2.diff (2.3 KB) - added by iamfriendly 4 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 3.7
  • Version set to 2.9

@iamfriendly
4 years ago

#2 @iamfriendly
4 years ago

Added a patch to place the _deprecated_function() call as well as updated the docblock to indicate the function has been deprecated, too.

#3 @iamfriendly
4 years ago

  • Cc richard@… added

#4 @nacin
4 years ago

We should move this function to wp-admin/includes/deprecated.php. We should also remove the first part of the function that supports .htaccess and the root index.php file, and instead just return WP_CONTENT_DIR . $arg;

#5 @iamfriendly
4 years ago

Moving it makes absolute sense, I should have done that in the first place. Also just returning WP_CONTENT_DIR . $arg makes sense too, I just didn't want to amend the function too much. New Patch Added :)

@iamfriendly
4 years ago

#6 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 25201:

Move get_real_file_to_edit() to wp-admin/includes/deprecated.php. props iamfriendly. fixes #23680.

#7 @SergeyBiryukov
4 years ago

In 25208:

Move get_real_file_to_edit() upper in the file for consistency with the existing order of functions. Some phpdoc fixes and additions. see #23680.

Note: See TracTickets for help on using tickets.