Fatal error in WP_User_Query

[SergeyBiryukov]

To reproduce in single site:

1. Go to Users screen.
2. Enter a URL into the search input and click "Search Users".
3. You'll see a fatal error:

   Fatal error: Call to undefined function wp_is_large_network() in wp-includes/user.php on line 477
   

wp_is_large_network() is only defined in Multisite admin:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/ms.php#L696

This can be reproduced when using WP_User_Query on front-end as well (in single site and Multisite). Introduced in [19886].

[SergeyBiryukov]

23683.patch​ moves the function to ms-functions.php, which could also help in #22917.

[ryan]

Looks good.

[SergeyBiryukov]

23683.patch​ doesn't actually fix the error in single site. 23683.2.patch​ should do that.

[nacin]

Might be easier to read as:

elseif ( preg_match('|^https?://|', $search) && ! ( is_multisite() && wp_is_large_network( 'users' ) ) )

[SergeyBiryukov]

In 23664:

Fix fatal error in WP_User_Query when searching users by URL. Move wp_is_large_network() to wp-includes. fixes #23683 for trunk.

[SergeyBiryukov]

Reopening for 3.5.2 consideration.

[nacin]

Let's be a bit more conservative for 3.5.2 and simply aim to avoid the fatal error: 23683.diff​.

The problem with moving a function from one file to another is that if the update fails in some very unexpected and uncaught way, the function could suddenly exist twice, which will result in fatal errors. I'd rather try to just fix the fatal without possibly introducing others in a minor release. (Checksums would, of course, make this better.)

[nacin]

Sergey signed off on the plan in IRC.

[nacin]

In 24441:

Avoid a fatal error in WP_User_Query. See #23683, [23664]. For the 3.5 branch.