WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #23688, comment 11


Ignore:
Timestamp:
04/25/13 09:51:24 (12 months ago)
Author:
trevHCS
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23688, comment 11

    initial v1  
    44I am wondering whether normalising the blog_charset would maybe be better done within get_option() rather than a specific new function?  
    55 
    6 Reasoning being there are 3 PHP 5.4 functions where this change to UTF-8 was made: 
     6Reasoning being there are 4x PHP 5.4 functions where this change to UTF-8 was made: 
    77 
    88htmlspecialchars() 
    99htmlentities() 
    1010html_entity_decode() 
     11get_html_translation_table() [not sure this is used in WP] 
    1112 
    1213There are already scripts within WP core which use the proposed get_option('blog_charset') fix as documented below, so fixing it in a new function wouldn't actually help those if the charset was incorrect.