WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#23695 closed enhancement (fixed)

Add orientation information to gallery items

Reported by: obenland Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Gallery Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

It would be highly beneficial for Twenty Thirteen to have information about image orientation for the way it implements galleries on index (#23649). Adding it in gallery_shortcode() would make it available to all themes, and would make it easier to style images in different orientations differently.

Plugins like Jetpack currently do their own orientation detection, something that could easily become obsolete.

Attachments (1)

23695.diff (823 bytes) - added by obenland 7 years ago.

Download all attachments as: .zip

Change History (8)

@obenland
7 years ago

#1 @lancewillett
7 years ago

Patch looks good. Assuming we don't need escaping for the class value since the two possible values are hard-coded?

#2 @lancewillett
7 years ago

Noting a quick "just looked at it, seems fine" from Nacin in IRC today. We'd like to get this in before freeze so we can finalize Twenty Thirteen's gallery handling and avoid adding custom code to the theme.

#3 @SergeyBiryukov
7 years ago

  • Keywords commit added

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 23649:

Add orientation information to gallery items. props obenland. fixes #23695.

#5 @SergeyBiryukov
7 years ago

  • Type changed from defect (bug) to enhancement

#6 follow-up: @TobiasBg
7 years ago

Should the CSS classes maybe be prefixed with "orientation-" or something similar?

#7 in reply to: ↑ 6 @SergeyBiryukov
7 years ago

Replying to TobiasBg:

Should the CSS classes maybe be prefixed with "orientation-" or something similar?

A quick IRC discussion: https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-03-08&sort=asc#m571516

Note: See TracTickets for help on using tickets.