WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#23698 closed defect (bug) (fixed)

Twenty Thirteen: Minor changes

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by lancewillett)

A ticket for truly minor changes that almost don't deserve their own ticket.

To get started:

  • Add 1px to top "margin" for second level menus
  • Remove text-decoration on hover for cancel-comment-reply-link
  • Pull floated images only in post content and only if they are medium or thumbnail
  • Align comment-bypostauthor star correctly

Attachments (4)

23698.menu.diff (376 bytes) - added by obenland 2 years ago.
Align child menus with parent height
23698.reply.diff (377 bytes) - added by obenland 2 years ago.
Remove text decoration on hover - there is no text
23698.edit.diff (675 bytes) - added by obenland 2 years ago.
Close edit link wrapper correctly
23698.float.diff (910 bytes) - added by obenland 2 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 @lancewillett2 years ago

  • Description modified (diff)
  • Keywords needs-patch added

Related: #23698

comment:2 @lancewillett2 years ago

  • Description modified (diff)

@obenland2 years ago

Align child menus with parent height

@obenland2 years ago

Remove text decoration on hover - there is no text

@obenland2 years ago

Close edit link wrapper correctly

@obenland2 years ago

comment:3 @obenland2 years ago

  • Keywords has-patch added; needs-patch removed

After testing I came to the conclusion that limiting the pull effect on floated images to medium and thumbnail sized images only is not a good idea. Chances are high that people will insert images that are full-size and not as wide as content width, which would lead to an inconsistent and confusion experience.

So we can't prevent glitches like here but we can prevent glitches like there.

comment:4 @lancewillett2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23629:

Twenty Thirteen: minor tweaks and fixes, props obenland. Fixes #23698.

  • Add 1px to top margin for second level menus to align child menus with parent height
  • Remove text-decoration on hover for cancel-comment-reply-link
  • Pull floated images only in post content
  • Close edit link span element correctly

comment:5 @SergeyBiryukov2 years ago

Align comment-bypostauthor star correctly

Fixed in [23630] (for #23696).

Note: See TracTickets for help on using tickets.