WordPress.org

Make WordPress Core

#23701 closed enhancement (fixed)

Twenty Thirteen: remove searchform.php template once core search form accepts HTML5 argument

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

See #15081 for the core change.

Once that lands in 3.6 we can remove searchform.php from the theme, and adjust any CSS selectors accordingly.

Attachments (4)

23701.diff (8.5 KB) - added by obenland 14 months ago.
23701.1.diff (8.0 KB) - added by obenland 14 months ago.
23701.2.diff (2.9 KB) - added by lancewillett 13 months ago.
23701.3.diff (3.0 KB) - added by lancewillett 13 months ago.

Download all attachments as: .zip

Change History (12)

obenland14 months ago

comment:1 obenland14 months ago

  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

comment:2 lancewillett14 months ago

Thanks for the patch -- can you break out twentythirteen_navbar_searchform() into a new ticket / patch please?

It's separate from the task here.

obenland14 months ago

comment:3 obenland14 months ago

Updated. Not sure we even need to append it through a filter. Would be easier to remove for child themes though.

comment:4 lancewillett14 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23673:

Twenty Thirteen: remove searchform.php template once core search form accepts HTML5 argument. Props obenland, fixes #23701.

comment:5 lancewillett13 months ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Changing the search form format to a filter, see #23850.

lancewillett13 months ago

comment:6 follow-up: obenland13 months ago

Could we add the callback in functions.php above the customizer code for code flow reasons?

comment:7 in reply to: ↑ 6 lancewillett13 months ago

  • Keywords has-patch added; needs-patch removed

Replying to obenland:

Could we add the callback in functions.php above the customizer code for code flow reasons?

Yep, good call.

lancewillett13 months ago

comment:8 lancewillett13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 23799:

Twenty Thirteen: remove HTML5 argument for search form, using a filter instead. See #23850, closes #23701.

Note: See TracTickets for help on using tickets.