Image metadata encoding problem

[pavelevap]

I uploaded picture DSCF4480.jpg (attached for testing).

Metadata for title and caption should be the same: "Bystřice u Benešova". But after upload title is right, but caption is damaged:

'caption' => 'Bystøice u Benešova',
'title' => 'Bystřice u Benešova'

Using latest trunk.

[SergeyBiryukov]

Introduced in [13244].

iptcparse() returns the correct caption, but the result from exif_read_data() overwrites it:
​http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/image.php#L244

This is what we get from iptcparse():

Array
(
    [aperture] => 0
    [credit] => mirekk
    [camera] => 
    [caption] => Přístupový chodník k 1.koleji (budoucí směr Tábor)
    [created_timestamp] => 0
    [copyright] => http://www.4koridor.cz
    [focal_length] => 0
    [iso] => 0
    [shutter_speed] => 0
    [title] => Bystřice u Benešova
)

This what we get later after merging with exif_read_data():

Array
(
    [aperture] => 3.2
    [credit] => mirekk
    [camera] => FinePix S9600
    [caption] => Byst�ice u Bene�ova
    [created_timestamp] => 1348422433
    [copyright] => http://www.4koridor.cz
    [focal_length] => 6.2
    [iso] => 100
    [shutter_speed] => 0.00666666666667
    [title] => Bystřice u Benešova
)

According to ​this reply, the EXIF:ImageDescription tag does not officially support UTF-8.

I guess we should only fill in the missing data instead of stomping on existing values.

[pavelevap]

Thank you, Sergey!

I tested your patch and it works really well!

[markjaquith]

Punting this as we're focusing on 3.6 blockers now. Let's get this done early in 3.7.

[pavelevap]

Tested with latest 3.6, there were probably some changes.

Title is the same, but caption is in database without encoding problem now. I am not sure what was changed?

The only strange thing is that caption value is saved in metadata, but displayed as Desription field (in Media library) and Caption field is empty (post_excerpt value)?

[nacin]

Sergey, if this is good to go, please commit.

[wonderboymusic]

In 28367:

In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty.

Props SergeyBiryukov.
Fixes #23706.

[pavelevap]

Please see my older comment: https://core.trac.wordpress.org/ticket/23706#comment:4

The only strange thing is that caption value is saved in metadata, but displayed as Desription field (in Media library) and Caption field is empty (post_excerpt value)?

And another note. We are saving these really long values into database (you can test attached image)? Is it really needed?

aperture = 3.20000000000000017763568394002504646778106689453125

shutter_speed = 0.0066666666666667

[helen]

Replying to pavelevap:

The only strange thing is that caption value is saved in metadata, but displayed as Desription field (in Media library) and Caption field is empty (post_excerpt value)?

#22768

And another note. We are saving these really long values into database (you can test attached image)? Is it really needed?

Why not keep data that's there? Also, that doesn't seem like a part of this ticket.

[pavelevap]

Sorry, I did not notice related ticket.

Should I create another ticket for strange values? I am not sure if it is worth it, but numbers are really long, not sure if really used for something with that presision...