Relax wildcard restrictions for populate_network() when installing in subdomain mode

[rinatkhaziev]

I ran into the issue while trying to use wp-cli install-network command with --subdomains support.

Underlying core issue is that populate_network is trying to check if wildcard subdomain is accessible. This makes sense for large networks, but might not work with certain setups, or not needed for small sites.

Proposed solution is to add extra arg for populate_network() $wildcard_check with default to true. See attached patch

[rinatkhaziev]

Proposed patch for the ticket

[nacin]

I don't see a problem necessarily with this patch. But, WP-CLI should check the returned WP_Error code and treat no_wildcard_dns as a warning, not a failure. If you look in wp-admin/network.php, we do the same.

I think it is probably time to turn populate_network() into an array of arguments.

[nacin]

Merged: ​https://github.com/wp-cli/wp-cli/pull/346.

[rinatkhaziev]

Thanks for wp-cli patch Andrew. I think this additional parameter still would be good for other edge cases.

[nacin]

I wonder if this wildcard check should be pulled out of populate_network(), and instead be done directly in wp-admin/network.php. (Wrapped into a function for wp-admin/includes/ms.php.) It is more of an application flow check than something that should be done at the schema/upgrade API level.

[SergeyBiryukov]

Related: #14862

[jeremyfelt]

Sounds like we may really have two tickets here.

1. Start supporting an array of arguments in populate_network(), in the process possibly addressing the original issue brought up in this ticket.
2. Move the wildcard subdomain check out of populate_network().

[chriscct7]

Closing as maybelater. Complete lack of interest on the feature on the ticket over the last 2 years. Feel free to reopen when more interest re-emerges (particularly if there's a patch).

[jeremyfelt]

Expressing some interest. :)

Let's poke at the idea of moving the wildcard DNS check out of populate_network(). It is a core workflow thing.

[DrewAPicture]

@jeremyfelt: And update on a new patch for this per comment:10?

[jeremyfelt]

Replying to DrewAPicture:

@jeremyfelt: And update on a new patch for this per comment:10?

I started digging a bit, but we still need a patch.

[jeremyfelt]

There's probably a bunch of fun to be had in populate_network(). Let's keep looking at this for 4.5.