Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#23723 closed defect (bug) (fixed)

Don't force '(time_diff) ago' sequence in the post revision information

Reported by: vanillalounge Owned by: ryan
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: I18N Keywords: has-patch commit
Focuses: Cc:


Some languages (Portuguese, for one) express this the other way around, i.e. '(string) (time_diff)'.

Example: '3 days ago' translates to 'há 3 dias' ('ago' is 'há')


Attachments (1)

23723.patch (2.8 KB) - added by johnbillion 3 years ago.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Version set to trunk

Introduced in [23506].

#2 @toscho
3 years ago

  • Cc info@… added

The whole string should be translatable. The placeholders need numbers, and the string should get a context parameter explaining what they are for.

In German it would be: Vor drei Tagen (date).

#3 @johnbillion
3 years ago

  • Keywords has-patch added

Patch which adds context and a translator comment.

#4 @SergeyBiryukov
3 years ago

  • Keywords commit added

#5 @SergeyBiryukov
3 years ago

Version 0, edited 3 years ago by SergeyBiryukov (next)

3 years ago

#6 @johnbillion
3 years ago

Updated the patch to add in the other missing i18n.

#7 @SergeyBiryukov
3 years ago

Looks good.

The context in line 1493 is probably not necessary, since the string seems self-explanatory and is not used anywhere else. Wouldn't hurt though, I guess.

#8 @johnbillion
3 years ago

Yeah I thought it'd be better to have it than not.

#9 @ryan
3 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 23743:

Fix i18n for revision diff strings displaying human time.

Props johnbillion
fixes #23723

Note: See TracTickets for help on using tickets.