Pass $post into 'protected_title_format' and 'private_title_format' filters

[johnjamesjacoby]

Currently it's only possible to change these prefixes globally.

Being able to change these prefixes based on specific $post data would be helpful for narrowing down the scope, say to specific custom post types.

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

[SergeyBiryukov]

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

Passing $post to protected_title_format and private_title_format makes sense to me.

[johnjamesjacoby]

Replying to SergeyBiryukov:

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

I hadn't considered these. Very much agree this bit needs a rethink. Will repatch without that bit.

[obenland]

Needs refresh with filter documentation update.

[DrewAPicture]

refresh + hook docs

[DrewAPicture]

23724.3.patch​ adds the hook doc updates.

[SergeyBiryukov]

In 28571:

Pass $post to 'protected_title_format' and 'private_title_format' filters.

props johnjamesjacoby, DrewAPicture.
fixes #23724.