WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#23724 closed enhancement (fixed)

Pass $post into 'protected_title_format' and 'private_title_format' filters

Reported by: johnjamesjacoby Owned by: SergeyBiryukov
Milestone: 4.0 Priority: low
Severity: minor Version: 3.5
Component: Posts, Post Types Keywords: has-patch
Focuses: template Cc:

Description

Currently it's only possible to change these prefixes globally.

Being able to change these prefixes based on specific $post data would be helpful for narrowing down the scope, say to specific custom post types.

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

Attachments (3)

23724.patch (909 bytes) - added by johnjamesjacoby 3 years ago.
23724.2.patch (786 bytes) - added by johnjamesjacoby 3 years ago.
23724.3.patch (1.5 KB) - added by DrewAPicture 2 years ago.
refresh + hook docs

Download all attachments as: .zip

Change History (10)

#1 follow-up: @SergeyBiryukov
3 years ago

  • Version changed from trunk to 3.5

I noticed also that we don't pass $post into the 'the_title' filter, which could cut down on an additional get_post() call later if we pass it here. Obviously not essential, but wouldn't hurt.

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

Passing $post to protected_title_format and private_title_format makes sense to me.

#2 in reply to: ↑ 1 @johnjamesjacoby
3 years ago

Replying to SergeyBiryukov:

I've found 14 instances of applying the_title filter in current trunk. Changing it in one place would be inconsistent, so this should be done a separate ticket. Previous inconsistencies (passing only one parameter) were fixed in #13558 and #16688.

I hadn't considered these. Agree adding anything to 'the_title' should be consistent. Will repatch with that bit. Thanks for the heads up there.

Last edited 3 years ago by johnjamesjacoby (previous) (diff)

#3 @nacin
2 years ago

  • Component changed from Template to Posts, Post Types
  • Focuses template added

#4 @obenland
2 years ago

  • Keywords needs-refresh added

#5 @obenland
2 years ago

Needs refresh with filter documentation update.

@DrewAPicture
2 years ago

refresh + hook docs

#6 @DrewAPicture
2 years ago

  • Keywords needs-refresh removed
  • Milestone changed from Awaiting Review to 4.0

23724.3.patch adds the hook doc updates.

#7 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28571:

Pass $post to 'protected_title_format' and 'private_title_format' filters.

props johnjamesjacoby, DrewAPicture.
fixes #23724.

Note: See TracTickets for help on using tickets.