Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#23732 closed defect (bug) (fixed)

Twenty Thirteen: improve header area padding to ensure stable layout at any size screen

Reported by: jvisick77's profile jvisick77 Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Viewing Twenty Thirteen on Google TV, there is no side padding on the main title or navigation when zoomed in (which is default). The added padding in the media query doesn't apply. If padding was added to the base styles instead, it would adjust nicely.

Attachments (4)

2013-tv-before.JPG (67.7 KB) - added by jvisick77 10 years ago.
Twenty Thirteen on Google TV
2013-tv-after.JPG (72.4 KB) - added by jvisick77 10 years ago.
With padding adjusted
23732.patch (1.8 KB) - added by jvisick77 10 years ago.
Updated patch
nav padding 2013 ie8-7.png (20.6 KB) - added by jvisick77 10 years ago.
alignment in ie7/8

Download all attachments as: .zip

Change History (14)

@jvisick77
10 years ago

Twenty Thirteen on Google TV

@jvisick77
10 years ago

With padding adjusted

#1 @jvisick77
10 years ago

  • Keywords has-patch added

#2 @obenland
10 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Type changed from enhancement to defect (bug)

I like the patch, it has the added bonus of never coming in the situation weher we have not enough padding, like right before the 1069px media query kicks in.

jvisick77, would you mind refreshing the patch? The IE8 style should be moved into /css/ie.css and I think we can also remove the .site-header hgroup selector around line 2700. Could you also make sure to create the patch from WordPress' root directory? Thank you! :)

@jvisick77
10 years ago

Updated patch

#3 @jvisick77
10 years ago

Yeah, I like not relying on media queries for padding if possible. I adjusted alignment for IE7 too.

#4 @lancewillett
10 years ago

  • Priority changed from normal to low

#5 @lancewillett
10 years ago

  • Priority changed from low to normal
  • Summary changed from Twenty Thirteen: no side padding on main title and nav when viewed on google tv to Twenty Thirteen: improve header area padding to ensure stable layout at any size screen

#6 @lancewillett
10 years ago

Patch looks good. I tested in a bunch of screen sizes and browsers.

#7 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23678:

Twenty Thirteen: improve header area padding to ensure stable layout at any size screen. Props jvisick77, fixes #23732. (Small props also to Google TV for revealing the bug.)

#8 follow-up: @jvisick77
10 years ago

@lancewillet I'm not sure if this was intentional for other reasons, but the following adjustment to the header width in ie.css was dropped in the update. Without it the alignment is off for ie8/7.

.site-header hgroup {

max-width: 1040px;

}

@jvisick77
10 years ago

alignment in ie7/8

#9 in reply to: ↑ 8 @lancewillett
10 years ago

Replying to jvisick77:

I'm not sure if this was intentional for other reasons

Nope, wasn't on purpose. Probably my mistake or patch didn't apply cleanly for some reason. I'll fix it.

#10 @lancewillett
10 years ago

In 23688:

Twenty Thirteen: adjust header max-width value for older IE browsers. Props jvisick77, see #23732.

Note: See TracTickets for help on using tickets.