Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#23742 closed defect (bug) (fixed)

Twenty Thirteen: thumbnails not aligning in galleries when thumbnail size bigger than 150

Reported by: RDall Owned by: lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


The Thumbnails are not aligning in the twenty thirteen gallery.

The details:

8 images in single post gallery view.
The thumbnail size was increased to 200px from the default 150px.
Gallery set to 3 column view
Caption on the second image is 40 words long and a typical caption.

The text at the bottom of the page is in the content are of the page and not in the gallery.

If the gallery is set to 2 column the view is still the same.
If the gallery is set to 1 column the images do follow the one column and the caption is aligned left.

Once the long caption has been hidden the thumbnails should float 3 columns across.

See dev build http://sandbox.robertdall.com/?p=16

Attachments (1)

23742.diff (2.5 KB) - added by obenland 9 years ago.

Download all attachments as: .zip

Change History (10)

9 years ago

#1 @obenland
9 years ago

  • Keywords has-patch added; needs-patch removed

#2 @obenland
9 years ago

  • Milestone changed from Awaiting Review to 3.6

#3 @lancewillett
9 years ago

Can you both please test after r23671 changes? Or is it not caption related?

#4 @obenland
9 years ago

No, it's not. It's image width related. If the thumbnail size is set to a value higher than the default 150px.

#5 @lancewillett
9 years ago

  • Keywords reporter-feedback added
  • Priority changed from normal to low

#6 @lancewillett
9 years ago

  • Keywords reporter-feedback removed
  • Summary changed from Thumbnails not aligning in gallery of Twenty Thirteen to Twenty Thirteen: thumbnails not aligning in galleries when thumbnail size bigger than 150

#7 @RDall
9 years ago

Still seeing same layout with patch applied. http://sandbox.robertdall.com/?p=16

It's the max-width of the gallery on line 1020 of the style.css file. The max width has been set to 606px which is forcing any larger sized thumbnails clear to the next line. We could increase the width to 610px which would resolve the problem if the thumbnails were 200px and smaller. Unless this has been set to this size for other reasons… 

You probably saying to yourself well why doesn't this guy just submit his own patch… Sadly I don't know how to create a diff file yet.

#8 @obenland
9 years ago

I'm not sure the patch attached to this ticket is actually applied on your blog.

On the issue of submitting patches, maybe this document can get you started.

#9 @lancewillett
9 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 23675:

Twenty Thirteen: gallery styles fixed to allow image thumbnails larger than 150 to align properly. Props obenland, fixes #23742.

Note: See TracTickets for help on using tickets.