WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 11 years ago

#23743 closed defect (bug) (fixed)

TinyMCE overwrites text edits when wpautop is false

Reported by: wraithkenny's profile WraithKenny Owned by: azaozz's profile azaozz
Milestone: 3.6 Priority: normal
Severity: major Version: 3.3
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

The logic at ​http://core.trac.wordpress.org/browser/trunk/wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js#L219 is inverted.

Patch fixes.

Attachments (2)

23743.diff​ (1.2 KB) - added by WraithKenny 13 years ago.
23743-nocomments.patch​ (832 bytes) - added by WraithKenny 13 years ago.

Download all attachments as: .zip

Change History (10)

@WraithKenny
13 years ago

#1 @WraithKenny
13 years ago

The possible permutations are:

  1. 'wpautop' = false, ed.hidden()
  2. 'wpautop' = true, ed.hidden()
  3. 'wpautop' = false, ! ed.hidden()
  4. 'wpautop' = true, ! ed.hidden()

Case 1. is the problem, wherein (without the patch) ed.onSaveContent will overwrite the text edits with the old content stored in the Visual editor. The patch only changes the behavior of Case 1.

#2 @WraithKenny
13 years ago

  • Version set to 2.9

#3 @WraithKenny
13 years ago

related to #17144 version should be 3.3, sorry.

#4 @SergeyBiryukov
13 years ago

  • Component changed from Editor to TinyMCE
  • Milestone changed from Awaiting Review to 3.6
  • Version changed from 2.9 to 3.3

#5 @SergeyBiryukov
13 years ago

  • Owner set to azaozz
  • Status changed from new to reviewing

@WraithKenny
13 years ago

#6 @WraithKenny
13 years ago

  • Cc Ken@… added

#7 @azaozz
13 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 23745:

Editor: preserve the textarea content when saving, wpautop is not used and TinyMCE is hidden. Props WraithKenny, fixes #23743

#8 @azaozz
11 years ago

#23476 was marked as a duplicate.

Note: See TracTickets for help on using tickets.