Make WordPress Core

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#23745 closed enhancement (wontfix)

Twenty Thirteen: Simplify responsive images

Reported by: obenland's profile obenland Owned by:
Milestone: Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description (last modified by obenland)

I think we could lose a lot of code for responsive images by being less selective. Themes like Able have proven it's sufficiency.

Attachments (1)

23745.diff (1.2 KB) - added by obenland 13 years ago.

Download all attachments as: .zip

Change History (5)

@obenland
13 years ago

#1 @obenland
13 years ago

  • Description modified (diff)

#2 @lancewillett
13 years ago

I prefer not to generalize this, we've tested the existing styles extensively in previous default themes and they work well.

I'd vote "wontfix".

#3 @lancewillett
13 years ago

The main reason we can't do this is because of user-generated markup in posts/pages. Users can change the width/height directly in their markup, and if we force height: auto; on those images their modifications won't work correctly.

That's why for height we target WP-generated class values specifically.

Also, a general selector would try to do this for all images in the site, like those added by a plugin. A "Like" button, for example, from Jetpack. That could lead to lots of unintended consequences.

#4 @obenland
13 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Let me close this, apparently there has been a lot of thought put into the current way of doing this.

Note: See TracTickets for help on using tickets.