add_role require string does not check for empty string

[Kenshino]

<?php add_role( $role, $display_name, $capabilities ); ?>

add_role works with $role as ''.

Perhaps it should check for empty string before allowing it to be added?

[Kenshino]

Couldn't put single quotes

[michielhab]

23746.diff

[michielhab]

Added check on $role in function add_role. If empty then return. 23746.diff

[dannydehaan]

I've made a little change in the patch of Michiel. In his patch in the file wp-includes/capabilities.php:164 the script is checking if $this->roles[$role] isset. After that the script is checking if $role isset. I've switched those 2 if's.

[dannydehaan]

23746-2

[wonderboymusic]

In 33967:

Ensure that role is not empty before adding it in add_role() function and methods.

Props MikeHansenMe, dannydehaan, michielhab.
Fixes #23746.